asterisk/asterisk.git
13 years agoMerged revisions 231911 via svnmerge from
Jeff Peeler [Tue, 1 Dec 2009 21:54:21 +0000 (21:54 +0000)]
Merged revisions 231911 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r231911 | jpeeler | 2009-12-01 15:29:31 -0600 (Tue, 01 Dec 2009) | 12 lines

  Fix crash with invalid frame data

  The crash was happening as a result of a frame containing an invalid data
  pointer, but was set with data length of zero. The few times the issue was
  reproduced it _seemed_ that the frame was queued properly, that is the data
  pointer was set to NULL. I never could reproduce the crash so as a last resort
  the crash has been fixed, but a check in __ast_read has been added to give as
  much information about the source of problematic frames in the future.

  (closes issue #16058)
  Reported by: atis
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@231927 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 231853 via svnmerge from
David Vossel [Tue, 1 Dec 2009 21:20:19 +0000 (21:20 +0000)]
Merged revisions 231853 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r231853 | dvossel | 2009-12-01 15:14:31 -0600 (Tue, 01 Dec 2009) | 3 lines

  WaitExten m option with no parameters generates frame with zero datalen but non-null data ptr
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@231867 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMore 32->64 bit codec conversions.
Tilghman Lesher [Tue, 1 Dec 2009 20:27:37 +0000 (20:27 +0000)]
More 32->64 bit codec conversions.
In the process of swapping ULAW to a place in the extended codec space, we
found several unhandled cases, where a 32-bit integer was still being used to
handle a codec field.  Most of these have been fixed with this commit, although
there is at least one case (codec_dahdi) which depends upon outside headers to
be altered before a conversion can be made.
(Fixes AST-278, SWP-459)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@231850 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoFormats need to be able to represent all 64 codec bits.
Tilghman Lesher [Tue, 1 Dec 2009 17:48:54 +0000 (17:48 +0000)]
Formats need to be able to represent all 64 codec bits.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@231814 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 231740 via svnmerge from
Matthew Nicholson [Tue, 1 Dec 2009 15:47:36 +0000 (15:47 +0000)]
Merged revisions 231740 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r231740 | mnicholson | 2009-12-01 09:34:57 -0600 (Tue, 01 Dec 2009) | 2 lines

  Ignore unknown formats in ast_format_str_reduce() and return an error if no know formats are found.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@231741 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoAnother round of UDPTL stack fixes/improvements:
Kevin P. Fleming [Mon, 30 Nov 2009 21:47:42 +0000 (21:47 +0000)]
Another round of UDPTL stack fixes/improvements:

1) Allow users of UDPTL stack to associate a character-string tag with a UDPTL
   session, so that log/error/debug messages generated by the UDPTL stack can
   be 'connected' to the endpoint that caused them to be generated.

2) Improve comments (and process) of calculating the far end's maximum IFP size
   when redundancy mode is in use for error correction.

3) When an IFP larger than the calculated 'far max IFP' size is presented for
   writing, truncate it rather than putting in the buffer and allowing the buffer
   to overflow; this will cause the ends to retrain to a lower bit rate that
   produces IFPs of an appropriate size if possible, and if not possible, the
   FAX transfer will fail completely. In these cases, it is due to the one endpoint
   supplying a T38FaxMaxDatagram value that is improperly calculated and is
   too low to be of use; we have configuration options available to override
   this behavior.

4) Eliminate use of T38FaxMaxDatagram value in udptl.conf; it is no longer
   needed.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@231692 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 231614 via svnmerge from
Matthew Nicholson [Mon, 30 Nov 2009 21:31:55 +0000 (21:31 +0000)]
Merged revisions 231614 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r231614 | mnicholson | 2009-11-30 15:11:44 -0600 (Mon, 30 Nov 2009) | 8 lines

  Remove duplicate entries from voicemail format lists. This prevents app_voicemail from entering an infinite loop when the same format is specified twice in the format list.

  (closes issue #15625)
  Reported by: Shagg63
  Tested by: mnicholson

  Review: https://reviewboard.asterisk.org/r/429/
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@231688 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoReverted 231616
Matthew Nicholson [Mon, 30 Nov 2009 21:21:29 +0000 (21:21 +0000)]
Reverted 231616

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@231637 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 231614 via svnmerge from
Matthew Nicholson [Mon, 30 Nov 2009 21:13:42 +0000 (21:13 +0000)]
Merged revisions 231614 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r231614 | mnicholson | 2009-11-30 15:11:44 -0600 (Mon, 30 Nov 2009) | 8 lines

  Remove duplicate entries from voicemail format lists. This prevents app_voicemail from entering an infinite loop when the same format is specified twice in the format list.

  (closes issue #15625)
  Reported by: Shagg63
  Tested by: mnicholson

  Review: https://reviewboard.asterisk.org/r/429/
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@231616 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoWhen receiving SDP that matches the version of the last one do not treat it as a...
Joshua Colp [Mon, 30 Nov 2009 20:44:30 +0000 (20:44 +0000)]
When receiving SDP that matches the version of the last one do not treat it as a fatal error.

(closes issue #16238)
Reported by: seandarcy

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@231602 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoapp_queue crashes randomly, often during call-transfers
David Vossel [Mon, 30 Nov 2009 18:55:07 +0000 (18:55 +0000)]
app_queue crashes randomly, often during call-transfers

This patch adds a ref to the queue_ent object's parent call_queue
in queue_exec() so the call_queue won't be destroyed
while the the queue_ent still holds a pointer to it.

(closes issue 0015686)
Tested by: dvossel, aragon

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@231556 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 231441 via svnmerge from
David Vossel [Mon, 30 Nov 2009 17:28:28 +0000 (17:28 +0000)]
Merged revisions 231441 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r231441 | dvossel | 2009-11-30 11:14:08 -0600 (Mon, 30 Nov 2009) | 11 lines

  fixes crash caused by RTP comfort noise payload greater than 24 bytes

  AST-2009-010

  (closes issue #16242)
  Reported by: amorsen
  Patches:
        issue16242.diff uploaded by oej (license 306)
  Tested by: amorsen, oej, dvossel
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@231491 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoExport dynamic (weak-linked) symbols correctly.
Tilghman Lesher [Mon, 30 Nov 2009 16:53:10 +0000 (16:53 +0000)]
Export dynamic (weak-linked) symbols correctly.
(closes issue #15193)
 Reported by: eliel
 Patches:
       20091111__issue15193.diff.txt uploaded by tilghman (license 14)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@231439 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoBlocked revisions 231437 via svnmerge
David Vossel [Mon, 30 Nov 2009 16:37:33 +0000 (16:37 +0000)]
Blocked revisions 231437 via svnmerge

........
  r231437 | dvossel | 2009-11-30 10:32:58 -0600 (Mon, 30 Nov 2009) | 18 lines

  app_queue crashes randomly, often during call-transfers

  In app_queue, it is possible for a call_queue to be destroyed
  while another object still holds a pointer to it.  This patch
  converts call_queue objects to ao2 objects allowing them to be
  ref counted.  This makes it safe for the queue_ent object in
  queue_exec() to reference it's parent call_queue even after it
  has left the queue.

  (closes issue #15686)
  Reported by: Hatrix
  Patches:
        v2_queue_ao2.diff uploaded by dvossel (license 671)
  Tested by: dvossel, aragon

  Review: https://reviewboard.asterisk.org/r/427/
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@231438 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoFix a bug where an immediate masquerade would cause a queued unhold frame to get...
Joshua Colp [Mon, 30 Nov 2009 16:29:29 +0000 (16:29 +0000)]
Fix a bug where an immediate masquerade would cause a queued unhold frame to get lost. Now we just
indicate unhold directly after the masquerade is complete.

(issue ABE-2011)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@231436 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years ago1. Modified exported variable names.
TransNexus OSP Development [Fri, 27 Nov 2009 08:47:18 +0000 (08:47 +0000)]
1. Modified exported variable names.
2. Added destination port support.
3. Added new protocols.
4. Added QoS.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@231401 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoReorder option flags. Change guidelines so that example code is consistent with...
Tilghman Lesher [Thu, 26 Nov 2009 02:09:58 +0000 (02:09 +0000)]
Reorder option flags.  Change guidelines so that example code is consistent with guidelines

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@231369 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 231298 via svnmerge from
Tilghman Lesher [Wed, 25 Nov 2009 22:33:02 +0000 (22:33 +0000)]
Merged revisions 231298 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r231298 | tilghman | 2009-11-25 16:31:57 -0600 (Wed, 25 Nov 2009) | 2 lines

  After a frame duplication failure, unlock the channel before returning.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@231299 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoBlocked revisions 231235 via svnmerge
David Vossel [Wed, 25 Nov 2009 21:39:00 +0000 (21:39 +0000)]
Blocked revisions 231235 via svnmerge

........
  r231235 | dvossel | 2009-11-25 15:38:32 -0600 (Wed, 25 Nov 2009) | 9 lines

  fixes solaris segfault on dial with verbosity >= 3

  (closes issue #16193)
  Reported by: asgaroth
  Patches:
        bug_16193_1.4.21.2_vers.diff uploaded by snuffy (license 35)
  Tested by: asgaroth, snuffy
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@231236 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoBlocked revisions 231233 via svnmerge
David Vossel [Wed, 25 Nov 2009 21:24:31 +0000 (21:24 +0000)]
Blocked revisions 231233 via svnmerge

........
  r231233 | dvossel | 2009-11-25 15:23:41 -0600 (Wed, 25 Nov 2009) | 8 lines

  fixes conditional jump or move depending on uninitialised STACK value

  (closes issue #16261)
  Reported by: edguy3
  Patches:
        edguy16261.patch uploaded by edguy3 (license 917)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@231234 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoLoad pbx_lua with global symbols to allow linking with other lua libraries.
Matthew Nicholson [Wed, 25 Nov 2009 15:42:48 +0000 (15:42 +0000)]
Load pbx_lua with global symbols to allow linking with other lua libraries.

Found by Maxim Litnitskiy.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@231189 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoFound a few places where queue refcounts were counted incorrectly. Also add debug...
Tilghman Lesher [Tue, 24 Nov 2009 20:31:28 +0000 (20:31 +0000)]
Found a few places where queue refcounts were counted incorrectly.  Also add debug statements.
(closes issue #15982, closes issue #15984)
 Reported by: atis
 Patches:
       20091111__issue15982.diff.txt uploaded by tilghman (license 14)
 Tested by: atis

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@231134 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoFix erroneous hangup extension execution
Jeff Peeler [Tue, 24 Nov 2009 18:50:36 +0000 (18:50 +0000)]
Fix erroneous hangup extension execution

ast_spawn_extension behaves differently from 1.4 in that hangups and extensions
that do not exist do not return an error, whereas in 1.6 it does. This is now
taken into account so that the AST_FLAG_BRIDGE_HANGUP_RUN flag gets set
properly.

(closes issue #16106)
Reported by: ajohnson
Tested by: ajohnson

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@231095 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoFix problem on digital channels due to digital flag not getting set
Jeff Peeler [Tue, 24 Nov 2009 17:12:25 +0000 (17:12 +0000)]
Fix problem on digital channels due to digital flag not getting set

Changed areas in sig_pri to set the digital flag using a callback that will
also set the corresponding flag in chan_dahdi. Modified dahdi_request slightly
so that if a bearer is marked as digital, that information is available when
creating the new channel.

(closes issue #16151)
Reported by: alecdavis
Patch based on bug_16151.diff.txt uploaded by alecdavis (license 585)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@231058 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoUpdated CHANGES file to describe the new 'd' option to app_followme added in r230964
Matthew Nicholson [Tue, 24 Nov 2009 13:52:21 +0000 (13:52 +0000)]
Updated CHANGES file to describe the new 'd' option to app_followme added in r230964

(related to issue #14155)
Reported by: junky

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@231025 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoAdd REPLACE & PASSTHRU functions, overhaul of func_strings, fix API docs for the...
Tilghman Lesher [Tue, 24 Nov 2009 04:58:44 +0000 (04:58 +0000)]
Add REPLACE & PASSTHRU functions, overhaul of func_strings, fix API docs for the ast_get_encoded_* functions.
 * Add REPLACE function, which searches a given variable for a set of
   characters and replaces each with a given character.
 * Add PASSTHRU function, which passes a literal string back, like a NoOp for
   functions.  Intent is to be able to specify a literal string to another
   function that takes a variable name as an argument.
 * Let the array manipulation functions work with dialplan functions, in
   addition to variables.  This allows the array manipulation functions to
   modify ASTDB and ODBC backends, assuming the func_odbc configuration has
   both read and write functions.
(closes issue #15223)
 Reported by: ajohnson
Patches:
       20091112__issue15223.diff.txt uploaded by tilghman (license 14)
 Tested by: lmadsen, tilghman

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@230994 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoAdd an option to app_followme to disable the "please hold" announcement.
Matthew Nicholson [Mon, 23 Nov 2009 22:37:39 +0000 (22:37 +0000)]
Add an option to app_followme to disable the "please hold" announcement.

(closes issue #14155)
Reported by: junky
Patches:
      M14555-trunk.diff uploaded by junky (license 177) (modified)
Tested by: junky

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@230964 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoChange fax detection in chan_sip so it behaves as one would expect.
Joshua Colp [Mon, 23 Nov 2009 15:45:45 +0000 (15:45 +0000)]
Change fax detection in chan_sip so it behaves as one would expect.

Internally the way T.38 is negotiated has changed and the option no longer
reflects a behavior that is valid. It will now look for a CNG tone on
received calls and if present send the call to the 'fax' extension. It is
then up to the application or channel to request the switch over to T.38.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@230881 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 230839 via svnmerge from
Kevin P. Fleming [Mon, 23 Nov 2009 15:34:16 +0000 (15:34 +0000)]
Merged revisions 230839 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r230839 | kpfleming | 2009-11-23 09:09:24 -0600 (Mon, 23 Nov 2009) | 1 line

  Correct fix for issue #16268... the reporter's original patch was very close to correct.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@230877 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoBlocked revisions 230875 via svnmerge
Kevin P. Fleming [Mon, 23 Nov 2009 15:33:02 +0000 (15:33 +0000)]
Blocked revisions 230875 via svnmerge

........
  r230875 | kpfleming | 2009-11-23 09:31:02 -0600 (Mon, 23 Nov 2009) | 7 lines

  When 'sip set debug' is enabled, and the last line of an incoming SIP message
  is not properly newline terminated, ensure that that line is included in the
  debug output.

  (part of issue #16268)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@230876 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 230772 via svnmerge from
Kevin P. Fleming [Mon, 23 Nov 2009 14:15:48 +0000 (14:15 +0000)]
Merged revisions 230772 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r230772 | kpfleming | 2009-11-23 08:13:56 -0600 (Mon, 23 Nov 2009) | 5 lines

  Ensure that SDP parsing does not ignore the last line of the SDP.

  (closes issue #16268)
  Reported by: sgimeno
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@230773 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agofixes iax2 show cache locking error, thanks alecdavis!
David Vossel [Fri, 20 Nov 2009 22:35:54 +0000 (22:35 +0000)]
fixes iax2 show cache locking error, thanks alecdavis!

(closes issue #16094)
Reported by: alecdavis
Patches:
      bug16094.diff.txt uploaded by alecdavis (license 585)
Tested by: alecdavis, dvossel

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@230726 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoRevert code in error and include the gcc suggested workaround for the original proble...
Tilghman Lesher [Fri, 20 Nov 2009 21:47:39 +0000 (21:47 +0000)]
Revert code in error and include the gcc suggested workaround for the original problem, while gcc investigates.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@230697 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 230627 via svnmerge from
Matthew Nicholson [Fri, 20 Nov 2009 21:01:10 +0000 (21:01 +0000)]
Merged revisions 230627 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r230627 | mnicholson | 2009-11-20 14:53:06 -0600 (Fri, 20 Nov 2009) | 8 lines

  Copy the peer CDR's userfield to the bridge CDR if it exists.  This is necessary for the recordagentcalls option in chan_agent to store the recorded file name in the bridge CDR.

  (closes issue #14590)
  Reported by: msetim
  Patches:
        queue_agent_userfield.patch uploaded by Laureano (license 265)
  Tested by: Laureano, mnicholson
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@230628 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoFix/Implement error events for non-existing files
David Ruggles [Fri, 20 Nov 2009 17:28:01 +0000 (17:28 +0000)]
Fix/Implement error events for non-existing files
also include a better cmd define for S command

Review: https://reviewboard.asterisk.org/r/430/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@230584 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoaudiohook signal trigger on every status change
David Vossel [Fri, 20 Nov 2009 17:26:20 +0000 (17:26 +0000)]
audiohook signal trigger on every status change

(issue #14618)

Review: https://reviewboard.asterisk.org/r/434/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@230583 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 230508 via svnmerge from
David Vossel [Thu, 19 Nov 2009 21:26:21 +0000 (21:26 +0000)]
Merged revisions 230508 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r230508 | dvossel | 2009-11-19 15:22:46 -0600 (Thu, 19 Nov 2009) | 10 lines

  fixes MixMonitor thread not exiting when StopMixMonitor is used

  (closes issue #16152)
  Reported by: AlexMS
  Patches:
        stopmixmonitor_1.4.diff uploaded by dvossel (license 671)
  Tested by: dvossel, AlexMS

  Review: https://reviewboard.asterisk.org/r/424/
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@230509 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoBasic cleanup of ExternalIVR: cleaned up argument parsing; implemented good coding...
David Ruggles [Thu, 19 Nov 2009 14:53:58 +0000 (14:53 +0000)]
Basic cleanup of ExternalIVR: cleaned up argument parsing; implemented good coding practices where applicable; replaced most notice level logging with verbose logging; replaced warning messages that terminated with error messages; fixed memory leak identified by russellb

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@230438 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoFix another buglet in T.38 session teardown at the end of FAX sessions.
Kevin P. Fleming [Mon, 16 Nov 2009 16:40:25 +0000 (16:40 +0000)]
Fix another buglet in T.38 session teardown at the end of FAX sessions.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@230381 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoEnsure that only one end of a T.38 session initiates teardown at completion.
Kevin P. Fleming [Mon, 16 Nov 2009 12:51:59 +0000 (12:51 +0000)]
Ensure that only one end of a T.38 session initiates teardown at completion.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@230343 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years ago1. Added SIP Diversion support.
TransNexus OSP Development [Mon, 16 Nov 2009 01:49:41 +0000 (01:49 +0000)]
1. Added SIP Diversion support.
2. Fixed compile warning for UUID.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@230314 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 230246 via svnmerge from
Kevin P. Fleming [Sun, 15 Nov 2009 17:23:02 +0000 (17:23 +0000)]
Merged revisions 230246 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r230246 | kpfleming | 2009-11-15 11:19:06 -0600 (Sun, 15 Nov 2009) | 6 lines

  Correct mistaken option name in error message.

  The configuration option for allowing hosts to make non-token-based calls
  is 'calltokenoptional', not 'calltokenignore'. (reported on asterisk-users)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@230247 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoIncrease maximum length of language buffers
Tilghman Lesher [Sun, 15 Nov 2009 07:53:16 +0000 (07:53 +0000)]
Increase maximum length of language buffers
(closes issue #16217)
 Reported by: dsessions

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@230217 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 230144 via svnmerge from
Joshua Colp [Fri, 13 Nov 2009 22:00:44 +0000 (22:00 +0000)]
Merged revisions 230144 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r230144 | file | 2009-11-13 16:00:19 -0600 (Fri, 13 Nov 2009) | 8 lines

  Respect the maddr parameter in the Via header.

  (closes issue #14446)
  Reported by: frawd
  Patches:
        via_maddr.patch uploaded by frawd (license 610)
  Tested by: frawd
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@230145 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoDisplay a list of channel variables in each channel-oriented event.
Tilghman Lesher [Fri, 13 Nov 2009 20:42:03 +0000 (20:42 +0000)]
Display a list of channel variables in each channel-oriented event.
(Closes AST-33)
Reviewboard: https://reviewboard.asterisk.org/r/368/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@230111 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 230038 via svnmerge from
Joshua Colp [Fri, 13 Nov 2009 19:44:53 +0000 (19:44 +0000)]
Merged revisions 230038 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r230038 | file | 2009-11-13 13:44:07 -0600 (Fri, 13 Nov 2009) | 9 lines

  Fix a crash caused by two threads thinking they should both free the
  chan_local private structure when only one should.

  (closes issue #15314)
  Reported by: sroberts
  Patches:
        Issue15314_Move_Nulling_owner.patch uploaded by davidw (license 780)
  Tested by: davidw, lottc
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@230039 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoStore the cause code that is returned when trying to create a channel in ChanIsAvail...
Joshua Colp [Fri, 13 Nov 2009 17:22:47 +0000 (17:22 +0000)]
Store the cause code that is returned when trying to create a channel in ChanIsAvail in the
AVAILCAUSECODE dialplan variable instead of overwriting the device state in AVAILSTATUS.

(closes issue #14426)
Reported by: macli

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229970 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 229965 via svnmerge from
Joshua Colp [Fri, 13 Nov 2009 17:20:26 +0000 (17:20 +0000)]
Merged revisions 229965 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r229965 | file | 2009-11-13 11:19:59 -0600 (Fri, 13 Nov 2009) | 6 lines

  Document a limitation in the AVAILSTATUS variable from ChanIsAvail and provide
  a workaround for it that does not change existing behavior.

  (closes issue #14426)
  Reported by: macli
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229966 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoFix T.38 negotiation regression introduced with the SDP parser changes.
Joshua Colp [Fri, 13 Nov 2009 15:56:16 +0000 (15:56 +0000)]
Fix T.38 negotiation regression introduced with the SDP parser changes.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229912 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoFixing trunk in a way so that it compiles again.
Olle Johansson [Fri, 13 Nov 2009 10:53:14 +0000 (10:53 +0000)]
Fixing trunk in a way so that it compiles again.

Thanks, Philippe :-)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229871 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoIf CDR logging is disabled, it's considered a FAILURE
Olle Johansson [Fri, 13 Nov 2009 09:22:04 +0000 (09:22 +0000)]
If CDR logging is disabled, it's considered a FAILURE

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229840 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoAdd the capability to require a module to be loaded, or else Asterisk exits.
Olle Johansson [Fri, 13 Nov 2009 08:52:28 +0000 (08:52 +0000)]
Add the capability to require a module to be loaded, or else Asterisk exits.

Review: https://reviewboard.asterisk.org/r/426/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229819 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoAdded full number portability parameter support.
TransNexus OSP Development [Fri, 13 Nov 2009 03:16:39 +0000 (03:16 +0000)]
Added full number portability parameter support.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229788 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoUpdate sample config for ALSA mute and noaudiocapture
Jason Parker [Thu, 12 Nov 2009 23:43:28 +0000 (23:43 +0000)]
Update sample config for ALSA mute and noaudiocapture

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229754 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoAdd mute functionality. Add config option to not try to open capture device.
Jason Parker [Thu, 12 Nov 2009 23:37:36 +0000 (23:37 +0000)]
Add mute functionality.  Add config option to not try to open capture device.

Adds "console {mute|unmute}" CLI command.
Adds mute and noaudiocapture config options (will update sample configs shortly).

(closes issue #14673)
Reported by: Nick_Lewis
Patches:
      chan_alsa.c-oneway3.patch uploaded by Nick Lewis (license 657)
Tested by: qwell

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229753 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoFix mute toggling on OSS channels.
Jason Parker [Thu, 12 Nov 2009 23:30:10 +0000 (23:30 +0000)]
Fix mute toggling on OSS channels.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229750 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 229669 via svnmerge from
David Vossel [Thu, 12 Nov 2009 16:44:39 +0000 (16:44 +0000)]
Merged revisions 229669 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r229669 | dvossel | 2009-11-12 10:41:49 -0600 (Thu, 12 Nov 2009) | 6 lines

  fixes merging error, datastore was being freed in the wrong function.

  (closes issue #16219)
  Reported by: aragon
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229670 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoUpdate sip.conf.sample.
Leif Madsen [Thu, 12 Nov 2009 13:54:45 +0000 (13:54 +0000)]
Update sip.conf.sample.
Just updating a spelling error and some capitalization in a
documentation update that Olle added. May the Swenglish be
with you.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229639 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoClarification
Olle Johansson [Thu, 12 Nov 2009 10:24:20 +0000 (10:24 +0000)]
Clarification

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229607 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoClarify some security issues early in the sample configuration
Olle Johansson [Thu, 12 Nov 2009 10:22:30 +0000 (10:22 +0000)]
Clarify some security issues early in the sample configuration

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229606 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoRemove non-functional feature from ExternalIVR documentation
David Ruggles [Wed, 11 Nov 2009 20:47:06 +0000 (20:47 +0000)]
Remove non-functional feature from ExternalIVR documentation

Remove non-functional socket implementation of ExternalIVR from documentation

(closes issue #16225)
Reported by: thedavidfactor
Patches:
      externalivr.txt.20091111.1542.patch uploaded by thedavidfactor (license 903)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229568 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 229498 via svnmerge from
David Brooks [Wed, 11 Nov 2009 19:48:18 +0000 (19:48 +0000)]
Merged revisions 229498 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r229498 | dbrooks | 2009-11-11 13:46:19 -0600 (Wed, 11 Nov 2009) | 8 lines

  Solaris doesn't like NULL going to ast_log

  Solaris will crash if NULL is passed to ast_log. This simple patch simply uses S_OR to
  get around this.

  (closes issue #15392)
  Reported by: yrashk
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229499 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoFlags not initialized in app_softhangup.c, causing undefined behavior
David Brooks [Wed, 11 Nov 2009 18:13:56 +0000 (18:13 +0000)]
Flags not initialized in app_softhangup.c, causing undefined behavior

Trivial patch [kobaz] to initialize an ast_flags = {0}

(closes issue #16129)
Reported by: kobaz

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229460 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoUpdate CHANGES file.
Leif Madsen [Wed, 11 Nov 2009 14:30:04 +0000 (14:30 +0000)]
Update CHANGES file.
Updating the CHANGES file after noticing an email on the asterisk-dev mailing
list from Russell.

(issue #15874)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229431 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 229360 via svnmerge from
Tilghman Lesher [Tue, 10 Nov 2009 22:14:22 +0000 (22:14 +0000)]
Merged revisions 229360 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r229360 | tilghman | 2009-11-10 16:09:16 -0600 (Tue, 10 Nov 2009) | 12 lines

  If two pattern classes start with the same digit and have the same number of characters, they will compare equal.
  The example given in the issue report is that of [234] and [246], which have
  these characteristics, yet they are clearly not equivalent.  The code still
  uses these two characteristics, yet when the two scores compare equal, an
  additional check will be done to compare all characters within the class to
  verify equality.
  (closes issue #15421)
   Reported by: jsmith
   Patches:
         20091109__issue15421__2.diff.txt uploaded by tilghman (license 14)
   Tested by: jsmith, thedavidfactor
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229361 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 229355 via svnmerge from
David Ruggles [Tue, 10 Nov 2009 22:01:50 +0000 (22:01 +0000)]
Merged revisions 229355 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r229355 | diruggles | 2009-11-10 16:45:15 -0500 (Tue, 10 Nov 2009) | 9 lines

  Fix ExternalIVR Documentation

  Remove documentation for event that doesn't function

  (closes issue #16220)
  Reported by: thedavidfactor
  Patches:
        externalivr.txt.20091110.1622.patch uploaded by thedavidfactor (license 903)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229356 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoWhen GOSUB is invoked within an AGI, it may not exit correctly.
Tilghman Lesher [Tue, 10 Nov 2009 21:22:50 +0000 (21:22 +0000)]
When GOSUB is invoked within an AGI, it may not exit correctly.
(closes issue #16216)
 Reported by: atis
 Patches:
       20091110__atis_work.diff.txt uploaded by tilghman (license 14)
 Tested by: atis

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229351 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 229281 via svnmerge from
Joshua Colp [Tue, 10 Nov 2009 20:06:13 +0000 (20:06 +0000)]
Merged revisions 229281 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r229281 | file | 2009-11-10 16:03:14 -0400 (Tue, 10 Nov 2009) | 8 lines

  Remove broken support for direct transcoding between G.726 RFC3551 and G.726 AAL2.

  On some systems the translation core would actually consider g726aal2 -> g726 -> signed linear
  to be a quicker path then g726aal2 -> signed linear which exposed this problem.

  (closes issue #15504)
  Reported by: globalnetinc
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229282 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 229191 via svnmerge from
David Ruggles [Tue, 10 Nov 2009 17:33:47 +0000 (17:33 +0000)]
Merged revisions 229191 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r229191 | diruggles | 2009-11-10 12:23:59 -0500 (Tue, 10 Nov 2009) | 11 lines

  Document ExternalIVR event tag collision

  ExternalIVR uses the D tag for two different event types. This documents that
  behavior and how to differentiate between the two cases. Also includes a minor
  spelling fix and clarification

  (closes issue #16211)
  Reported by: thedavidfactor
  Patches:
        externalivr.txt.20091109.1507.patch uploaded by thedavidfactor (license 903)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229228 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 229167 via svnmerge from
David Vossel [Tue, 10 Nov 2009 17:16:49 +0000 (17:16 +0000)]
Merged revisions 229167 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r229167 | dvossel | 2009-11-10 11:15:57 -0600 (Tue, 10 Nov 2009) | 9 lines

  don't crash on log message in solaris

  AST-2009-006

  (closes issue #16206)
  Reported by: bklang
  Tested by: bklang
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229168 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoReverted revision 201717.
Matthew Nicholson [Tue, 10 Nov 2009 15:53:52 +0000 (15:53 +0000)]
Reverted revision 201717.

(closes issue 0016175)
Reported by: paul-tg

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229102 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agofixes pgsql double free of threadstorage
David Vossel [Tue, 10 Nov 2009 15:27:45 +0000 (15:27 +0000)]
fixes pgsql double free of threadstorage

A thread storage variable was being freed incorrectly, which
resulted in a double free if two queries were made in the same thread.

(closes issue #16011)
Reported by: cristiandimache
Patches:
      issue16011.diff uploaded by dvossel (license 671)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229093 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoSchema file additions
Gavin Henry [Tue, 10 Nov 2009 11:16:10 +0000 (11:16 +0000)]
Schema file additions

* Added AsteriskDialplan, AsteriskAccount and AsteriskMailbox  objectClasses
  to allow standalone dialplan, account and mailbox entries (STRUCTURAL)
* Added new Fields:
- AstAccountLanguage, AstAccountTransport, AstAccountPromiscRedir,
- AstAccountAccountCode, AstAccountSetVar, AstAccountAllowOverlap,
- AstAccountVideoSupport, AstAccountIgnoreSDPVersion
* Removed redundant IPaddr (there's already IPAddress)
- Gives more configuration Flags for SIP-Users available (tested)
- Allows to create Asterisk Attributes in defined Asterisk ObjectClasses
  without extensibleObject (which really should be the last resort); gives
  also additional possibilities for LDAP-filter

(closes issue #15874)
Reported by: Medozas
Patches:
      asterisk.ldap-schema.patch uploaded by Medozas (license 41)
Tested by: Medozas, suretec

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229050 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoDon't crash when bridge->tech_pvt == NULL
Terry Wilson [Mon, 9 Nov 2009 22:50:22 +0000 (22:50 +0000)]
Don't crash when bridge->tech_pvt == NULL

This is a similar solution to what is in place for chan_agent

(closes issue #16003)
Reported by: atis
Tested by: twilson

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@229015 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoDon't try to convert a 64-bit integer, where only a 32-bit integer is stored.
Tilghman Lesher [Mon, 9 Nov 2009 17:17:29 +0000 (17:17 +0000)]
Don't try to convert a 64-bit integer, where only a 32-bit integer is stored.
(closes issue #16194)
 Reported by: habile

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@228979 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoAdd the 'relative-periodic-announce' option to app_queue to allow for calculating...
Matthew Nicholson [Mon, 9 Nov 2009 16:28:31 +0000 (16:28 +0000)]
Add the 'relative-periodic-announce' option to app_queue to allow for calculating the time of announcments from the end of the previous announcment rather than from the beginning.

(closes issue #15260)
Reported by: tonils

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@228947 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 228896 via svnmerge from
Leif Madsen [Mon, 9 Nov 2009 15:38:38 +0000 (15:38 +0000)]
Merged revisions 228896 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r228896 | lmadsen | 2009-11-09 09:37:43 -0600 (Mon, 09 Nov 2009) | 6 lines

  Update WARNING message.
  Update a WARNING message to give a suggested fix when encountered.

  (closes issue #16198)
  Reported by: atis
  Tested by: atis
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@228897 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 228827 via svnmerge from
Matthew Nicholson [Mon, 9 Nov 2009 14:37:07 +0000 (14:37 +0000)]
Merged revisions 228827 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r228827 | mnicholson | 2009-11-09 08:16:03 -0600 (Mon, 09 Nov 2009) | 8 lines

  Perform limited bounds checking when destroying ast_mutex_t structures to make sure we don't try to use negative indices.

  (closes issue #15588)
  Reported by: zerohalo
  Patches:
        20090820__issue15588.diff.txt uploaded by tilghman (license 14)
  Tested by: zerohalo
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@228858 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoFix various problems detected with Valgrind.
Tilghman Lesher [Mon, 9 Nov 2009 07:37:52 +0000 (07:37 +0000)]
Fix various problems detected with Valgrind.
 * chan_console accessed pvts after deallocation.
 * cdr_mysql stored a pointer that was freed by realloc()
 * The module loader did not check usecount on shutdown, which led to chan_iax2
 reading a timer that was already unloaded.
 * The event subsystem sometimes creates an event with no IEs.  Due to a corner
 condition, the code would read beyond the memory boundary.
 * res_pktccops did not correctly check whether its monitor thread was started.
(closes issue #16062)
 Reported by: alexanderheinz
 Patches:
       20091109__issue16062.diff.txt uploaded by tilghman (license 14)
 Tested by: tilghman

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@228798 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoAdd LSB headers to the Debian init.d script
Tzafrir Cohen [Sat, 7 Nov 2009 17:02:38 +0000 (17:02 +0000)]
Add LSB headers to the Debian init.d script

See also issue #14864 .

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@228766 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 228692 via svnmerge from
David Vossel [Fri, 6 Nov 2009 22:35:44 +0000 (22:35 +0000)]
Merged revisions 228692 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r228692 | dvossel | 2009-11-06 16:33:27 -0600 (Fri, 06 Nov 2009) | 9 lines

  fixes audiohook write crash occuring in chan_spy whisper mode.

  After writing to the audiohook list in ast_write(), frames
  were being freed incorrectly.  Under certain conditions this
  resulted in a double free crash.

  (closes issue #16133)
  Reported by: wetwired

  (closes issue #16045)
  Reported by: bluecrow76
  Patches:
        issue16045.diff uploaded by dvossel (license 671)
  Tested by: bluecrow76, dvossel, habile
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@228693 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoCreated standard location to add options to chan_dahdi for ISDN dialing.
Richard Mudgett [Fri, 6 Nov 2009 22:32:17 +0000 (22:32 +0000)]
Created standard location to add options to chan_dahdi for ISDN dialing.

Dial(DAHDI/g1[/extension[/options]])
Current options:
K(<keypad_digits>)
R Reverse charging indication (Collect calls)

The earlier Dial(DAHDI/g1[/K<keypad_digits>][/extension] format was
variable and did not allow for the easy addition of more options.

The earlier 'C' prefix character for reverse charge indiation would
conflict with the a-d DTMF digits if ISDN uses them.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@228691 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoami_testhooks.c automatically registers hook
David Brooks [Fri, 6 Nov 2009 22:07:22 +0000 (22:07 +0000)]
ami_testhooks.c automatically registers hook

ami_testhooks.c was registering for AMI events upon module load. Moved the registration
to its own CLI command. Added CLI command for unregistering the hook. Changed some of
the wording, removed unnecessary arguments/parameters.

Reported by: rmudgett

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@228661 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMake compilation of chan_ooh323 disabled by default.
Mark Michelson [Fri, 6 Nov 2009 22:02:36 +0000 (22:02 +0000)]
Make compilation of chan_ooh323 disabled by default.

All addons modules should be disabled by default, requiring the
user to turn them on if desired. After all, these are addons we're
talking about here.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@228659 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoGet chan_ooh323 to compile with gcc 4.2.
Mark Michelson [Fri, 6 Nov 2009 22:00:12 +0000 (22:00 +0000)]
Get chan_ooh323 to compile with gcc 4.2.

For some reason, the code compiles just fine with later versions
of GCC, but this one requires some weird double casting in order
to get rid of all warnings. Whatever.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@228658 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoFix compiler warning gcc 4.2.4 found
Richard Mudgett [Fri, 6 Nov 2009 19:53:08 +0000 (19:53 +0000)]
Fix compiler warning gcc 4.2.4 found

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@228621 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 228378 via svnmerge from
Matthew Nicholson [Fri, 6 Nov 2009 19:47:11 +0000 (19:47 +0000)]
Merged revisions 228378 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r228378 | mnicholson | 2009-11-06 10:26:59 -0600 (Fri, 06 Nov 2009) | 8 lines

  Properly handle '=' while decoding base64 messages and null terminate strings returned from BASE64_DECODE.

  (closes issue #15271)
  Reported by: chappell
  Patches:
        base64_fix.patch uploaded by chappell (license 8)
  Tested by: kobaz
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@228620 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMissed these two channel drivers on the codec_bits merge
Tilghman Lesher [Fri, 6 Nov 2009 19:38:33 +0000 (19:38 +0000)]
Missed these two channel drivers on the codec_bits merge

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@228616 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 228547 via svnmerge from
Joshua Colp [Fri, 6 Nov 2009 18:37:59 +0000 (18:37 +0000)]
Merged revisions 228547 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r228547 | file | 2009-11-06 14:32:58 -0400 (Fri, 06 Nov 2009) | 4 lines

  Don't overwrite caller ID name on a trunk with the configured fullname when using users.conf

  (issue ABE-1989)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@228548 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoFix the localchannel.tex file.
Joshua Colp [Fri, 6 Nov 2009 17:52:00 +0000 (17:52 +0000)]
Fix the localchannel.tex file.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@228499 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoFixes merging issue from 1.4, frame data is held in data.ptr in trunk
David Vossel [Fri, 6 Nov 2009 17:22:31 +0000 (17:22 +0000)]
Fixes merging issue from 1.4, frame data is held in data.ptr in trunk

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@228441 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 228418 via svnmerge from
David Vossel [Fri, 6 Nov 2009 17:09:01 +0000 (17:09 +0000)]
Merged revisions 228418 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r228418 | dvossel | 2009-11-06 11:07:13 -0600 (Fri, 06 Nov 2009) | 13 lines

  fixes segfault in iLBC

  For reasons not yet known, it appears possible for an ast_frame
  to have a datalen greater than zero while the actual data is NULL
  during Packet Loss Concealment.  Most codecs don't support PLC so
  this doesn't affect them.  This patch catches the malformed frame
  and prevents the crash from occuring.  Additional efforts to determine
  why it is possible for a frame to look like this are still being
  investigated.

  (issue #16979)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@228420 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 228409 via svnmerge from
Joshua Colp [Fri, 6 Nov 2009 16:42:23 +0000 (16:42 +0000)]
Merged revisions 228409 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r228409 | file | 2009-11-06 12:41:20 -0400 (Fri, 06 Nov 2009) | 7 lines

  Fix a bug caused by a partially invalid frame (from the jitterbuffer) passing through the Asterisk core.

  (closes issue #15560)
  Reported by: jvandal
  (closes issue #15709)
  Reported by: covici
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@228410 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 228338 via svnmerge from
David Vossel [Fri, 6 Nov 2009 15:42:46 +0000 (15:42 +0000)]
Merged revisions 228338 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r228338 | dvossel | 2009-11-06 09:41:41 -0600 (Fri, 06 Nov 2009) | 5 lines

  fixes crash in astfd.c

  (closes issue #15981)
  Reported by: slavon
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@228339 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoBlocked revisions 228272 via svnmerge
David Vossel [Fri, 6 Nov 2009 15:08:04 +0000 (15:08 +0000)]
Blocked revisions 228272 via svnmerge

........
  r228272 | dvossel | 2009-11-06 09:07:31 -0600 (Fri, 06 Nov 2009) | 9 lines

  fixes memory leak in func_audiohookinherit.c

  (closes issue 0015394)
  Reported by: boroda
  Patches:
        bug15394_memoryleak_diff2.txt uploaded by dbrooks (license 790)
  Tested by: dbrooks, boroda
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@228273 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agofixes memory leak in func_audiohookinherit.c
David Vossel [Fri, 6 Nov 2009 15:04:24 +0000 (15:04 +0000)]
fixes memory leak in func_audiohookinherit.c

(closes issue #15394)
Reported by: boroda
Patches:
      bug15394_memoryleak_diff2.txt uploaded by dbrooks (license 790)
Tested by: dbrooks, boroda

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@228268 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoFix XML in func_cdr.c
Mark Michelson [Thu, 5 Nov 2009 22:59:02 +0000 (22:59 +0000)]
Fix XML in func_cdr.c

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@228233 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoYet another error message in the dialplan (thanks, rmudgett/russellb)
Tilghman Lesher [Thu, 5 Nov 2009 22:12:45 +0000 (22:12 +0000)]
Yet another error message in the dialplan (thanks, rmudgett/russellb)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@228196 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMEETME_INFO should not return a literal error message to the dialplan.
Tilghman Lesher [Thu, 5 Nov 2009 21:24:21 +0000 (21:24 +0000)]
MEETME_INFO should not return a literal error message to the dialplan.
(closes issue #15450)
 Reported by: JimVanM
 Patches:
       meetmeinfopatch.diff.txt uploaded by dbrooks (license 790)
 Tested by: JimVanM

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@228191 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoFix the fix for chanspy option o
Jeff Peeler [Thu, 5 Nov 2009 21:23:06 +0000 (21:23 +0000)]
Fix the fix for chanspy option o

In 224178, I assumed the uploaded patch was correct as it had received positive
feedback. The flags were being checked in the incorrect location. Upon testing
the fix this time it was also found that the flags from the dialplan weren't
being copied to the chanspy_translation_helper.

(closes issue #16167)
Reported by: marhbere

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@228189 65c4cc65-6c06-0410-ace0-fbb531ad65f3