asterisk/asterisk.git
15 years agoFix usage of rtptimeout. It can be used without rtpkeepalive, and the value can not...
Joshua Colp [Mon, 17 Dec 2007 15:18:58 +0000 (15:18 +0000)]
Fix usage of rtptimeout. It can be used without rtpkeepalive, and the value can not be accessed directly in the SIP pvt structure. All RTP related timeouts have to be retrieved using the ast_rtp_* function calls.
(closes issue #11562)
Reported by: ibc

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@93190 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoIf no timezone is available use the default message.
Joshua Colp [Mon, 17 Dec 2007 13:39:53 +0000 (13:39 +0000)]
If no timezone is available use the default message.
(closes issue #11576)
Reported by: junky

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@93188 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMake chan_unistim actually be able to unload. When creating a thread that you want...
Joshua Colp [Mon, 17 Dec 2007 13:34:03 +0000 (13:34 +0000)]
Make chan_unistim actually be able to unload. When creating a thread that you want to pthread_join you have to explicitly create it as joinable, and also if using pthread_cancel you have to have a pthread_testcancel to see if it has been called.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@93187 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoBlocked revisions 93183 via svnmerge
Kevin P. Fleming [Mon, 17 Dec 2007 07:27:36 +0000 (07:27 +0000)]
Blocked revisions 93183 via svnmerge

........
r93183 | kpfleming | 2007-12-16 23:21:08 -0800 (Sun, 16 Dec 2007) | 2 lines

fix some copy-and-paste leftovers

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@93185 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 93180 via svnmerge from
Kevin P. Fleming [Mon, 17 Dec 2007 07:25:35 +0000 (07:25 +0000)]
Merged revisions 93180 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r93180 | kpfleming | 2007-12-16 22:44:51 -0800 (Sun, 16 Dec 2007) | 23 lines

In http://lists.digium.com/pipermail/asterisk-dev/2007-December/031145.html,
rizzo brought up some issues related to the way that the metadata required
for menuselect and the rest of the build system is extracted from the source
files. Since I had a few hours to kill on an airplane today, I decided to
improve this situation... so now the system caches the extracted metadata
and uses it to build the menuselect 'tree' as much as it can. The result
of this is that when a single source file is changed, only the metadata for
that file needs to be extracted again, and the rest is used from the cache
files. I also reduced the number of forked processes required to do the
metadata extraction; it was actually possible to do most of what we needed
in the Makefiles themselves without using any shell scripts at all! On my
laptop, these changes resulted in an 80% decrease in the time required
for the 'menuselect.makeopts' automatic check to occur after editing a single
source file.

While doing this work I also cleaned up a few minor things in the Makefiles,
adding a check for 'awk' to the configure script and changed all remaining
places we use 'grep' or 'awk' to use the ones found by the configure script,
and changed the 'prep_tarball' script to build the menuselect metadata so
that tarballs of Asterisk will include it and won't require the user to
wait while it is extracted after unpacking.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@93184 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agomenuselect.makeopts is not a .PHONY target
Luigi Rizzo [Sun, 16 Dec 2007 19:06:31 +0000 (19:06 +0000)]
menuselect.makeopts is not a .PHONY target

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@93173 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoConvert from LOG_DEBUG etc to ast_debug. Thanks, dimas!
Olle Johansson [Sun, 16 Dec 2007 13:38:25 +0000 (13:38 +0000)]
Convert from LOG_DEBUG etc to ast_debug. Thanks, dimas!

(closes issue #11572)
Reported by: dimas
Patches:
      dundilog-trunk.patch uploaded by dimas (license 88)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@93167 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoAdding a new CLI command for "manager reload", which is important now that
Olle Johansson [Sun, 16 Dec 2007 13:35:09 +0000 (13:35 +0000)]
Adding a new CLI command for "manager reload", which is important now that
you need to reload after changes. Thanks YS.

Reported by: ys
Patches:
      trunk93163_manager_reload.c.diff uploaded by ys (license 281)
(related to issue #11414)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@93166 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoChange manager so that registered accounts are stored in memory. This opens for a
Olle Johansson [Sun, 16 Dec 2007 13:32:48 +0000 (13:32 +0000)]
Change manager so that registered accounts are stored in memory. This opens for a
manager realtime implementation.

If you change accounts in manager.conf, you now need to reload to activate the
changes (deletions, additions). This was not the case with 1.4.

Reported by: ys
Patches:
      trunk93163_manager_reload.c.diff uploaded by ys (license 281)
(closes issue #11414)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@93165 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoAdding console_video to CHANGES. It's important that we keep this file up to date,
Olle Johansson [Sun, 16 Dec 2007 13:21:11 +0000 (13:21 +0000)]
Adding console_video to CHANGES. It's important that we keep this file up to date,
even with experimental stuff.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@93164 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoHUGE improvements to QoS/CoS handling by IgorG
Olle Johansson [Sun, 16 Dec 2007 10:51:53 +0000 (10:51 +0000)]
HUGE improvements to QoS/CoS handling by IgorG

- Refer to the proper documentation
- Implement separate signalling/media QoS/CoS in many channels using RTP
- Improve warnings and verbose messages
- Deprecate some old settings

Minor modifications by me, a big effort from IgorG.
Thanks!

Reported by: IgorG
Patches:
      qoscleanup-89394-4-trunk.patch uploaded by IgorG (license 20)
Tested by: IgorG
(closes issue #11145)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@93163 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agouse a simpler idiom for 'cmp -s ...'
Luigi Rizzo [Sun, 16 Dec 2007 10:34:55 +0000 (10:34 +0000)]
use a simpler idiom for 'cmp -s ...'

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@93162 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoDon't drop the first character randomly in long listings in the CLI.
Olle Johansson [Sun, 16 Dec 2007 09:37:41 +0000 (09:37 +0000)]
Don't drop the first character randomly in long listings in the CLI.

Reported by: slavon
Patches:
      asterisk-consolerefresh2.diff.txt uploaded by jamesgolovich (license 176)
Tested by: eliel
(closes issue #9325)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@93161 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoUpdate documentation
Olle Johansson [Sun, 16 Dec 2007 08:19:38 +0000 (08:19 +0000)]
Update documentation

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@93160 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMake more timers settable in SIP so that we can force timeout earlier on non-responsi...
Olle Johansson [Sun, 16 Dec 2007 08:15:31 +0000 (08:15 +0000)]
Make more timers settable in SIP so that we can force timeout earlier on non-responsive SIP servers.
Thanks, jcmoore, for the patch!

Reported by: jcmoore
Patches:
      peer_t1_timerb_trunk_v3.patch.txt uploaded by jcmoore (license 9)
(closes issue #9771)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@93159 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoTypo fixed earlier, that wasn't a typo after all.
Olle Johansson [Sat, 15 Dec 2007 11:34:33 +0000 (11:34 +0000)]
Typo fixed earlier, that wasn't a typo after all.
Didn't a clever guy once say "Compile before you commit" ?

:-)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@93152 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years ago fix a typo from revision 93138
Russell Bryant [Sat, 15 Dec 2007 08:10:32 +0000 (08:10 +0000)]
 fix a typo from revision 93138

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@93151 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoconfiguration options related to video support.
Luigi Rizzo [Sat, 15 Dec 2007 00:44:34 +0000 (00:44 +0000)]
configuration options related to video support.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@93145 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoBring in video console support for chan_oss (and later chan_alsa too).
Luigi Rizzo [Sat, 15 Dec 2007 00:30:15 +0000 (00:30 +0000)]
Bring in video console support for chan_oss (and later chan_alsa too).
This is disabled in the default build, you need to explicitly enable it
compiling with

make COPTS=-DHAVE_VIDEO_CONSOLE

In return, you will be able to do a video call with chan_oss, using
the webcam (or X11 grabbing) as local source, and rendering the
incoming stream on your screen. Currently supported formats are
h261, h263, h263+, h264, mpeg4 (all through the avcodec lib, part
of ffmpeg).

Incoming video is on the left, outgoing video is on the right,
while the center displays a keypad (if configured so).

Right clicking on the video windows increases the size,
center clicking reduces the size.
Dragging the mouse (with the left key) on the right window
while the X11 grabber is active moves the grab area.

This is the result of work by Sergio Fadda, Marta Carbone
and myself, all properly disclaimed to digium.

Note, there is a lot of work left to do in this module,
including adding support for Video4LinuxV2 (I have patches
from Matteo Brancaleoni which should be integrated),
and making the GUI a lot more friendly than it is now
(e.g. supporting merging or switching among multiple sources,
a text window, and more).

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@93144 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoremove some redundant headers
Luigi Rizzo [Sat, 15 Dec 2007 00:11:04 +0000 (00:11 +0000)]
remove some redundant headers

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@93143 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoinclude mmap header if detected by configure
Luigi Rizzo [Fri, 14 Dec 2007 23:33:24 +0000 (23:33 +0000)]
include mmap header if detected by configure

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@93138 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoResolve a compiler warning
Mark Michelson [Fri, 14 Dec 2007 22:02:18 +0000 (22:02 +0000)]
Resolve a compiler warning

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@93115 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoChange places where the name "INBOX" was hardcoded to use the imapfolder
Mark Michelson [Fri, 14 Dec 2007 21:40:34 +0000 (21:40 +0000)]
Change places where the name "INBOX" was hardcoded to use the imapfolder
setting from voicemail.conf instead. This commit will help to get issue
#11415 moving towards commitment.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@93094 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoSolaris compat fixes
Tilghman Lesher [Fri, 14 Dec 2007 21:09:17 +0000 (21:09 +0000)]
Solaris compat fixes
Reported by: snuffy
Patch by: snuffy,tilghman
(Closes issue #11315)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@93090 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agomake something static
Russell Bryant [Fri, 14 Dec 2007 19:31:25 +0000 (19:31 +0000)]
make something static

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@93067 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoRemove use of privacy.conf by the Privacy app.
Tilghman Lesher [Fri, 14 Dec 2007 19:27:54 +0000 (19:27 +0000)]
Remove use of privacy.conf by the Privacy app.
Reported by: eliel
Patch by: eliel
(Closes issue #11344)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@93066 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoI needed to increment the numbers used on the VERBOSITY_ATLEAST calls by 1.
Mark Michelson [Fri, 14 Dec 2007 19:19:07 +0000 (19:19 +0000)]
I needed to increment the numbers used on the VERBOSITY_ATLEAST calls by 1.

Thanks to kpfleming for pointing this out.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@93065 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoChanged VERBOSITY_LEVEL to VERBOSITY_ATLEAST to be more accurate.
Mark Michelson [Fri, 14 Dec 2007 18:54:48 +0000 (18:54 +0000)]
Changed VERBOSITY_LEVEL to VERBOSITY_ATLEAST to be more accurate.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@93063 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoAfter reading Russell's e-mail to the dev list stating that checking option_verbose...
Mark Michelson [Fri, 14 Dec 2007 18:47:44 +0000 (18:47 +0000)]
After reading Russell's e-mail to the dev list stating that checking option_verbose is not
equivalent to the check done by ast_verb, I wrote a macro, VERBOSITY_LEVEL, which does this
check. I did a quick look in the source and used this macro in some places where option_verbose
was used.

I also converted some verbose messages in logger.c to use ast_verb instead of ast_verbose.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@93042 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agogcc 4.1.3 wants a union used here.
Tilghman Lesher [Fri, 14 Dec 2007 18:24:12 +0000 (18:24 +0000)]
gcc 4.1.3 wants a union used here.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@93041 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoPrint an error message if a #included file does not exist
Russell Bryant [Fri, 14 Dec 2007 17:49:28 +0000 (17:49 +0000)]
Print an error message if a #included file does not exist

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@93004 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoBlocked revisions 93000 via svnmerge
Russell Bryant [Fri, 14 Dec 2007 17:38:11 +0000 (17:38 +0000)]
Blocked revisions 93000 via svnmerge

........
r93000 | russell | 2007-12-14 11:36:08 -0600 (Fri, 14 Dec 2007) | 7 lines

There are a lot of existing systems that #include non-existent files.  So, to
make the transition to treating this as an error a bit less painless, just issue
a huge error message for now.  Then, later, we can reinstate the code that treats
it as a failure.

(Thanks to philippel for the feedback)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@93001 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoPublish the AGI events to manager.
Tilghman Lesher [Fri, 14 Dec 2007 17:29:27 +0000 (17:29 +0000)]
Publish the AGI events to manager.
Reported by: moy
Patch by: moy,tilghman
(Closes issue #11337)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92999 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoReintroduce an optimization that was lost when converting trunk to use ast_verb.
Mark Michelson [Fri, 14 Dec 2007 15:59:09 +0000 (15:59 +0000)]
Reintroduce an optimization that was lost when converting trunk to use ast_verb.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92976 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoIf malloc.h is included in a Solaris build, the compilation breaks.
Tilghman Lesher [Fri, 14 Dec 2007 15:49:14 +0000 (15:49 +0000)]
If malloc.h is included in a Solaris build, the compilation breaks.
Reported by: snuffy
Patch by: snuffy
(Closes issue #11313)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92939 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 92937 via svnmerge from
Joshua Colp [Fri, 14 Dec 2007 15:18:10 +0000 (15:18 +0000)]
Merged revisions 92937 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r92937 | file | 2007-12-14 11:16:15 -0400 (Fri, 14 Dec 2007) | 4 lines

Up the length of the format on the SIP channel since it can now be rather long.
(closes issue #11552)
Reported by: francesco_r

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92938 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 92933 via svnmerge from
Tilghman Lesher [Fri, 14 Dec 2007 15:14:24 +0000 (15:14 +0000)]
Merged revisions 92933 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r92933 | tilghman | 2007-12-14 09:01:10 -0600 (Fri, 14 Dec 2007) | 5 lines

Change help documentation to match actual behavior (FAILURE vs FAILED).
Reported by: angeloxx-sir
Patch by: tilghman
(Closes issue #11548)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92936 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 92934 via svnmerge from
Christian Richter [Fri, 14 Dec 2007 15:08:09 +0000 (15:08 +0000)]
Merged revisions 92934 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r92934 | crichter | 2007-12-14 16:05:28 +0100 (Fr, 14 Dez 2007) | 1 line

fixed the sequencing of WAITING_4DIGS state setting and overlap_task thread starting.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92935 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoConvert ast_verbose to ast_verb.
Tilghman Lesher [Fri, 14 Dec 2007 14:48:38 +0000 (14:48 +0000)]
Convert ast_verbose to ast_verb.
Reported by: snuffy
Patch by: snuffy
(Closes issue #11547)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92913 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 92875 via svnmerge from
Mark Michelson [Fri, 14 Dec 2007 01:25:36 +0000 (01:25 +0000)]
Merged revisions 92875 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r92875 | mmichelson | 2007-12-13 19:24:06 -0600 (Thu, 13 Dec 2007) | 7 lines

When compiling with DETECT_DEADLOCKS, don't spam the CLI with messages
about possible deadlocks. Instead just print the intended single message every
five seconds.

(closes issue 11537, reported and patched by dimas)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92876 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoWhen working with dates, use numeric form whenever possible, as it's faster.
Tilghman Lesher [Thu, 13 Dec 2007 23:10:42 +0000 (23:10 +0000)]
When working with dates, use numeric form whenever possible, as it's faster.
Also, a bunch of coding guidelines fixes.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92855 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 92815 via svnmerge from
Tilghman Lesher [Thu, 13 Dec 2007 21:42:33 +0000 (21:42 +0000)]
Merged revisions 92815 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r92815 | tilghman | 2007-12-13 15:28:39 -0600 (Thu, 13 Dec 2007) | 5 lines

Properly initialize polarity statuses, so that they are detected properly.
Reported by: julianjm
Patch by: julianjm
(Closes issue #10238)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92816 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMove usage of the old LOCAL_USER_* macros to the new ast_module_user_* functions...
Joshua Colp [Thu, 13 Dec 2007 20:23:48 +0000 (20:23 +0000)]
Move usage of the old LOCAL_USER_* macros to the new ast_module_user_* functions in a few documentation places.
(closes issue #11533)
Reported by: IgorG
Patches:
      oldmacroclean.v1.diff uploaded by IgorG (license 20)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92811 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 92809 via svnmerge from
Jason Parker [Thu, 13 Dec 2007 20:14:26 +0000 (20:14 +0000)]
Merged revisions 92809 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r92809 | qwell | 2007-12-13 14:13:48 -0600 (Thu, 13 Dec 2007) | 1 line

Make application help text a little more clear about the use of extensions in a filename.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92810 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 92807 via svnmerge from
Mark Michelson [Thu, 13 Dec 2007 20:12:37 +0000 (20:12 +0000)]
Merged revisions 92807 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r92807 | mmichelson | 2007-12-13 14:03:20 -0600 (Thu, 13 Dec 2007) | 3 lines

Prevent another potential fd leak

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92808 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 92803 via svnmerge from
Mark Michelson [Thu, 13 Dec 2007 19:53:21 +0000 (19:53 +0000)]
Merged revisions 92803 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r92803 | mmichelson | 2007-12-13 13:49:55 -0600 (Thu, 13 Dec 2007) | 3 lines

Prevent a possible fd leak.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92806 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoDon't use backslash as an escape character, unless it really is an escape character.
Tilghman Lesher [Thu, 13 Dec 2007 17:46:04 +0000 (17:46 +0000)]
Don't use backslash as an escape character, unless it really is an escape character.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92779 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoRemove remnants of a poorly merged commit. (92697)
Jason Parker [Thu, 13 Dec 2007 16:23:50 +0000 (16:23 +0000)]
Remove remnants of a poorly merged commit. (92697)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92758 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoTag voicemails with UTC time as opposed to local time zone
Doug Bailey [Thu, 13 Dec 2007 15:40:19 +0000 (15:40 +0000)]
Tag voicemails with UTC time as opposed to local time zone

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92737 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 92696 via svnmerge from
Jason Parker [Thu, 13 Dec 2007 00:18:04 +0000 (00:18 +0000)]
Merged revisions 92696 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

(closes issue #10690)
........
r92696 | qwell | 2007-12-12 18:11:09 -0600 (Wed, 12 Dec 2007) | 7 lines

If a typo is found in a config file, we previous continued on with what was already loaded.
We do not want to do this (see bug below for details).

This makes it so that if a [ is found without a ], the entire config will fail, and nothing in it will be loaded.

Issue 10690.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92697 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoRevert an "optimization" that I added in revision 89887, as the user who reported
Russell Bryant [Wed, 12 Dec 2007 23:44:26 +0000 (23:44 +0000)]
Revert an "optimization" that I added in revision 89887, as the user who reported
issue #11449 has demonstrated that it actually was a performance hit on his
machine.  I think that it is possible that it could still be a benefit on systems
under higher load, especially SMP systems, but I don't have enough time or interest
to find out at the moment.
(closes issue #11449)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92676 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 92617 via svnmerge from
Jason Parker [Wed, 12 Dec 2007 21:22:58 +0000 (21:22 +0000)]
Merged revisions 92617 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

(closes issue #11048)
........
r92617 | qwell | 2007-12-12 15:15:45 -0600 (Wed, 12 Dec 2007) | 4 lines

Don't increment user count until after name has been recorded (if enabled).

Issue 11048, tested by pep.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92618 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoConversions of free to ast_free, where applicable, and several other formatting fixes.
Tilghman Lesher [Wed, 12 Dec 2007 20:05:13 +0000 (20:05 +0000)]
Conversions of free to ast_free, where applicable, and several other formatting fixes.
Reported by: eliel
Patch by: eliel,tilghman
(Closes issue #11209)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92594 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 92556 via svnmerge from
Russell Bryant [Wed, 12 Dec 2007 19:50:32 +0000 (19:50 +0000)]
Merged revisions 92556 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r92556 | russell | 2007-12-12 13:40:02 -0600 (Wed, 12 Dec 2007) | 1 line

resolve compiler warning
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92562 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoSame change to trunk as revision 92510. I'm not sure why I merged
Mark Michelson [Wed, 12 Dec 2007 17:51:50 +0000 (17:51 +0000)]
Same change to trunk as revision 92510. I'm not sure why I merged
this way, but I did.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92526 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoBlocked revisions 92510 via svnmerge
Mark Michelson [Wed, 12 Dec 2007 17:48:34 +0000 (17:48 +0000)]
Blocked revisions 92510 via svnmerge

........
r92510 | mmichelson | 2007-12-12 11:46:14 -0600 (Wed, 12 Dec 2007) | 7 lines

Correctly detect where a dynamic feature was activated. Before this patch,
the channel which initiated the bridge was always assumed to have been the one
which activated the dynamic feature. This patch corrects this.

(closes issue #11529, reported and patched by nic_bellamy)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92511 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoCorrectly handle possible memory allocation failure
Tilghman Lesher [Wed, 12 Dec 2007 17:15:56 +0000 (17:15 +0000)]
Correctly handle possible memory allocation failure
Reported by: eliel
Patch by: eliel
(Closes issue #11512)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92507 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 92463 via svnmerge from
Tilghman Lesher [Wed, 12 Dec 2007 16:56:12 +0000 (16:56 +0000)]
Merged revisions 92463 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r92463 | tilghman | 2007-12-12 10:52:56 -0600 (Wed, 12 Dec 2007) | 4 lines

Test directly for the API that fixed AST-2007-026, to ensure that older
versions of PostgreSQL are no longer acceptable.
(Closes issue #11526)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92476 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 92443 via svnmerge from
Mark Michelson [Wed, 12 Dec 2007 16:11:13 +0000 (16:11 +0000)]
Merged revisions 92443 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r92443 | mmichelson | 2007-12-12 10:08:55 -0600 (Wed, 12 Dec 2007) | 3 lines

Removing an unused variable.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92444 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoDoxygen updates, formatting.
Olle Johansson [Tue, 11 Dec 2007 22:20:22 +0000 (22:20 +0000)]
Doxygen updates, formatting.

misdn stuff needs a lot of doxygenification

(Hello, Qwell :-) )

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92423 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoTrunk build would fail due to the nonexistence of zaptel hwgain
Mark Michelson [Tue, 11 Dec 2007 22:10:43 +0000 (22:10 +0000)]
Trunk build would fail due to the nonexistence of zaptel hwgain
structures missing. Patched configure to check for this stuff and
put a #ifdef around the offending code in chan_zap. Thanks to file
for overseeing this.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92422 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoWe need to set the address we want to match against before we actually do the match..
Jason Parker [Tue, 11 Dec 2007 21:58:26 +0000 (21:58 +0000)]
We need to set the address we want to match against before we actually do the match..

Closes issue #11518.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92421 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoRemoving a pointless memset. The memory was just calloc'd, so the
Mark Michelson [Tue, 11 Dec 2007 21:46:16 +0000 (21:46 +0000)]
Removing a pointless memset. The memory was just calloc'd, so the
memory is already zeroed out

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92402 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoAdd variable to show which key was pressed to stop playback.
Jason Parker [Tue, 11 Dec 2007 21:17:37 +0000 (21:17 +0000)]
Add variable to show which key was pressed to stop playback.

Issue #11377, initial patch by johan.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92401 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoOnly look to see if options are set if some have been provided.
Joshua Colp [Tue, 11 Dec 2007 20:06:43 +0000 (20:06 +0000)]
Only look to see if options are set if some have been provided.
(closes issue #11505)
Reported by: Mike Anikienko

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92365 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 92363 via svnmerge from
Joshua Colp [Tue, 11 Dec 2007 19:52:37 +0000 (19:52 +0000)]
Merged revisions 92363 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r92363 | file | 2007-12-11 15:51:40 -0400 (Tue, 11 Dec 2007) | 6 lines

Fix potential memory leak with the dialed interfaces list if another memory allocation fails.
(closes issue #11507)
Reported by: eliel
Patches:
      global_datastores.c.patch uploaded by eliel (license 64)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92364 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 92323 via svnmerge from
Mark Michelson [Tue, 11 Dec 2007 17:44:42 +0000 (17:44 +0000)]
Merged revisions 92323 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r92323 | mmichelson | 2007-12-11 11:42:25 -0600 (Tue, 11 Dec 2007) | 10 lines

Fixing autofill to be more accurate. Specifically, if calls ahead of the current
caller were ringing members (but not yet bridged) there could be available members
and waiting callers who would not get matched up. The member availability checker
was correctly determining the number of available members in this scenario, but
the queue itself did not parallelly reflect this status on the pending calls. This
commit corrects the issue.

(closes issue #11459, reported by equissoftware, patched by me)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92324 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years ago* In unaligned.h, remove some unnecessary casts and mark the arg of the
Russell Bryant [Tue, 11 Dec 2007 16:29:29 +0000 (16:29 +0000)]
* In unaligned.h, remove some unnecessary casts and mark the arg of the
  get_unaligned functions as const
* In event.c, use get_unaligned_uint32() in a couple of places to fix issues on
  architectures that don't allow unaligned access

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92305 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoA lot of doxygen updates
Olle Johansson [Tue, 11 Dec 2007 14:17:29 +0000 (14:17 +0000)]
A lot of doxygen updates

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92285 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoDoxygen updates
Olle Johansson [Tue, 11 Dec 2007 09:26:25 +0000 (09:26 +0000)]
Doxygen updates

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92267 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoAdd CLI commands to dynamically set hw and sw gains
Doug Bailey [Mon, 10 Dec 2007 20:18:25 +0000 (20:18 +0000)]
Add CLI commands to dynamically set hw and sw gains

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92243 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoAdd ast_atomic_fetchadd_int_slow to check_expr for platforms that need it.
Joshua Colp [Mon, 10 Dec 2007 16:48:18 +0000 (16:48 +0000)]
Add ast_atomic_fetchadd_int_slow to check_expr for platforms that need it.
(closes issue #11484)
Reported by: snuffy

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92206 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 92204 via svnmerge from
Joshua Colp [Mon, 10 Dec 2007 16:37:35 +0000 (16:37 +0000)]
Merged revisions 92204 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r92204 | file | 2007-12-10 12:36:15 -0400 (Mon, 10 Dec 2007) | 6 lines

Add G729A as another possible payload name for G729. Some devices use this instead of G729, which is perfectly normal since the payload number itself is defined and can't be used by anything else so the name doesn't matter that much.
(closes issue #11483)
Reported by: revolution
Patches:
      rtp.diff uploaded by revolution (license 346)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92205 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 92202 via svnmerge from
Mark Michelson [Mon, 10 Dec 2007 16:30:46 +0000 (16:30 +0000)]
Merged revisions 92202 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r92202 | mmichelson | 2007-12-10 10:29:44 -0600 (Mon, 10 Dec 2007) | 7 lines

If there are no members in a queue, then the loop where the datastore for detecting
duplicate dialed numbers will be skipped, meaning the datastore isn't created. This means
that when we try to free it, there's a crash. This stops that crash from occurring.

(closes issue #11499, reported by slavon, patched by eliel)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92203 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoBlocked revisions 92200 via svnmerge
Joshua Colp [Mon, 10 Dec 2007 16:15:06 +0000 (16:15 +0000)]
Blocked revisions 92200 via svnmerge

........
r92200 | file | 2007-12-10 12:13:43 -0400 (Mon, 10 Dec 2007) | 4 lines

It is possible for nativeformats to contain more then one codec, so print out multiple ones.
(closes issue #11366)
Reported by: ovi

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92201 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoOnly send a SIGHUP if the pid is greater than -1, otherwise all PIDs greater than...
Joshua Colp [Mon, 10 Dec 2007 16:07:33 +0000 (16:07 +0000)]
Only send a SIGHUP if the pid is greater than -1, otherwise all PIDs greater than -1 will get the SIGHUP... and that is bad.
(closes issue #11453)
Reported by: alanmcmillan

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92199 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoRemoving some LOG_DEBUG items
Olle Johansson [Mon, 10 Dec 2007 14:18:21 +0000 (14:18 +0000)]
Removing some LOG_DEBUG items

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92160 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 92158 via svnmerge from
Olle Johansson [Mon, 10 Dec 2007 14:10:24 +0000 (14:10 +0000)]
Merged revisions 92158 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r92158 | oej | 2007-12-10 15:04:44 +0100 (MÃ¥n, 10 Dec 2007) | 16 lines

Avoid reinvite race situations with two Asterisks trying
to reinvite each other in 1.4 and trunk.

This patch implements support for the 491 error code that
Asterisk 1.4 generates on situations where we get an
incoming INVITE and already has one in progress.

Thanks to mavetju for reporting and to Raj Jain for an
excellent explanation of the problem.

Patch by myself. Tested with 8 Asterisk servers connected
to each other in a training network.

Closes issue #10481

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92159 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoAdd a few extra headers in the voicemail users listing in
Olle Johansson [Mon, 10 Dec 2007 13:29:57 +0000 (13:29 +0000)]
Add a few extra headers in the voicemail users listing in
manager 1.1. Update documentation too.

(closes issue #11495)
Reported by: caio1982
Patches:
      extra_vm_manager_info1.diff uploaded by caio1982 (license 22)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92140 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agosimplify/cleanup the scripts
Luigi Rizzo [Mon, 10 Dec 2007 09:00:44 +0000 (09:00 +0000)]
simplify/cleanup the scripts

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92122 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoremove relative paths and use ASTTOPDIR instead.
Luigi Rizzo [Mon, 10 Dec 2007 08:40:59 +0000 (08:40 +0000)]
remove relative paths and use ASTTOPDIR instead.

Give a default value to ASTTOPDIR if unset so we can at least
do a 'make clean' without too much trouble.

The proper fix, however, is to partition the top level
Makefile in a 'setup' and a 'main' part, in a way that the
'setup' part can be included from subdirs' Makefiles and
allow targets to be built without going through the
top level Makefile.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92104 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agosimplify this file
Luigi Rizzo [Mon, 10 Dec 2007 08:35:35 +0000 (08:35 +0000)]
simplify this file

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92103 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoadd a bit of info on the build infrastructure
Luigi Rizzo [Mon, 10 Dec 2007 04:38:49 +0000 (04:38 +0000)]
add a bit of info on the build infrastructure

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92084 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoFix the detection of modules installed from this build.
Luigi Rizzo [Mon, 10 Dec 2007 04:18:07 +0000 (04:18 +0000)]
Fix the detection of modules installed from this build.

You can now add the path of local module subdirs from the command line with
   make LOCAL_MOD_SUBDIRS= ....

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92083 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoPut into Makefile.moddir_rules the common instructions used to
Luigi Rizzo [Mon, 10 Dec 2007 03:50:38 +0000 (03:50 +0000)]
Put into Makefile.moddir_rules the common instructions used to
generate loadable and embedded module lists.

Individual Makefiles now are a lot simpler, possibly as simple as this:

    -include $(ASTTOPDIR)/menuselect.makeopts $(ASTTOPDIR)/menuselect.makedeps
    MODULE_PREFIX=cdr_
    all: _all
    include $(ASTTOPDIR)/Makefile.moddir_rules

and also more flexible because in a single directory we can combine
various types of modules (app_, cdr_, func_, ... ) by simply
listing them in the MODULE_PREFIX variable.

The individual Makefiles can also create list of modules to be
excluded by listing them in the variablel MODULE_EXCLUDE (see an
example in channels/Makefile).

With this change it becomes trivial to integrate a directory with
locally created/modified sources into the main build.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92082 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agomake the install target a bit less noisy
Luigi Rizzo [Mon, 10 Dec 2007 02:06:40 +0000 (02:06 +0000)]
make the install target a bit less noisy

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92063 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agodocument usage of several exported variables
Luigi Rizzo [Mon, 10 Dec 2007 01:54:40 +0000 (01:54 +0000)]
document usage of several exported variables

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92062 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoadd hashtab.c to the list of files deleted
Luigi Rizzo [Sun, 9 Dec 2007 22:55:58 +0000 (22:55 +0000)]
add hashtab.c to the list of files deleted

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92042 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoanother place where ../ should have been ASTTOPDIR
Luigi Rizzo [Sun, 9 Dec 2007 21:32:30 +0000 (21:32 +0000)]
another place where ../ should have been ASTTOPDIR

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92023 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agonormalize subdirs' Makefile by using ASTTOPDIR and not .. to reference
Luigi Rizzo [Sun, 9 Dec 2007 21:29:37 +0000 (21:29 +0000)]
normalize subdirs' Makefile by using ASTTOPDIR and not .. to reference
the top level directory.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92022 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoImplement the outcome of a discussion on the -dev list re. the use
Luigi Rizzo [Sun, 9 Dec 2007 16:47:25 +0000 (16:47 +0000)]
Implement the outcome of a discussion on the -dev list re. the use
of DESTDIR and INSTALL_PATH - many thanks to Tzafrir Cohen and
Simon Perreault for extremely useful feedback:

1. comment out the [directories] section the created asterisk.conf ;
   you can set the correct defaults at build time using INSTALL_PATH,
   so the repetition here is redundant and often wrong.
   (The next step now is move asterisk.conf outside the Makefile to
   asterisk.conf.sample, because there is little if anything here
   that needs to be constructed at build/install time).

2. use DESTDIR?=$(INSTALL_PATH) so you only need to specify a path
   once if the two coincide. This should have no ill side effects,
   because if you don't specify DESTDIR, you really need
   INSTALL_PATH="" to set the correct defaults, and if you specify
   DESTDIR the value is not overridden.

The second part required moving the 'export DESTDIR' right after
the assignment to prevent DESTDIR getting set by the export
(this is documented in the Makefile).o hopefully avoid the mistake)$

With this change you can now do something like this from your source tree:

make INSTALL_PATH=/some/place install samples

and then

main/asterisk -vdc

which will pick up the correct config files and libraries from
/some/place - i.e. great for developers!

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92002 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoremove unused code, and simplify the logic for #include/#exec
Luigi Rizzo [Sat, 8 Dec 2007 19:06:01 +0000 (19:06 +0000)]
remove unused code, and simplify the logic for #include/#exec
(still a lot of cleanup needed here).

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@91983 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoImplement comment_buffer and lline_buffer in terms of the ast_str_*() API.
Luigi Rizzo [Sat, 8 Dec 2007 18:50:32 +0000 (18:50 +0000)]
Implement comment_buffer and lline_buffer in terms of the ast_str_*() API.
I don't know if comment_buffers etc are actually used at all...

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@91962 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agounify some common code
Luigi Rizzo [Sat, 8 Dec 2007 18:18:28 +0000 (18:18 +0000)]
unify some common code

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@91953 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agonormalize formatting
Luigi Rizzo [Sat, 8 Dec 2007 18:05:42 +0000 (18:05 +0000)]
normalize formatting

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@91952 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agodocument a nice technique to exit from a block in case of errors.
Luigi Rizzo [Sat, 8 Dec 2007 17:58:08 +0000 (17:58 +0000)]
document a nice technique to exit from a block in case of errors.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@91951 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoa little bit of documentation on how lines are parsed.
Luigi Rizzo [Sat, 8 Dec 2007 03:47:19 +0000 (03:47 +0000)]
a little bit of documentation on how lines are parsed.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@91931 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agonormalize header order, and add a comment on the need
Luigi Rizzo [Sat, 8 Dec 2007 03:27:16 +0000 (03:27 +0000)]
normalize header order, and add a comment on the need
to clean up this file.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@91930 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agosome platforms (e.g. FreeBSD4) need netinet/in.h to be included
Luigi Rizzo [Sat, 8 Dec 2007 03:26:09 +0000 (03:26 +0000)]
some platforms (e.g. FreeBSD4) need netinet/in.h to be included
before arpa/inet.h

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@91929 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 91890 via svnmerge from
Jason Parker [Fri, 7 Dec 2007 23:32:09 +0000 (23:32 +0000)]
Merged revisions 91890 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

(closes issue #11273)
........
r91890 | qwell | 2007-12-07 17:29:01 -0600 (Fri, 07 Dec 2007) | 4 lines

We need to make sure we free the input frame if we return a different frame in ast_dsp_process.

Issue 11273, pointed out by dimas, with a patch by eliel.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@91891 65c4cc65-6c06-0410-ace0-fbb531ad65f3