Tilghman Lesher [Fri, 27 Jun 2008 20:38:59 +0000 (20:38 +0000)]
Separate multiple items encoded into a single field with ';'
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@126021
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Fri, 27 Jun 2008 19:19:08 +0000 (19:19 +0000)]
Fix a typo. Someone on IRC copied this literally and then wondered why it
wasn't working. :)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125988
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Matthew Fredrickson [Fri, 27 Jun 2008 19:05:40 +0000 (19:05 +0000)]
Revert this part of the fix. We'll fix it in libss7
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125984
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Matthew Fredrickson [Fri, 27 Jun 2008 19:00:44 +0000 (19:00 +0000)]
Obviously somebody didn't compile with libss7 support when doing the DAHDI conversion.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125982
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Matthew Fredrickson [Fri, 27 Jun 2008 18:32:17 +0000 (18:32 +0000)]
Add support for new commands to block/unblock all CICs on a linkset
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125980
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Brett Bryant [Fri, 27 Jun 2008 17:35:41 +0000 (17:35 +0000)]
Small error in the function that converts peer transports to a string.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125947
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Fri, 27 Jun 2008 17:02:56 +0000 (17:02 +0000)]
Document DLA_UNLOCK and DLA_LOCK
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125895
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Fri, 27 Jun 2008 16:48:05 +0000 (16:48 +0000)]
Blocked revisions 125893 via svnmerge
........
r125893 | tilghman | 2008-06-27 11:46:05 -0500 (Fri, 27 Jun 2008) | 7 lines
Since HAVE_DAHDI is defined to HAVE_ZAPTEL in dahdi_compat.h, we must first
check for HAVE_ZAPTEL.
(closes issue #12938)
Reported by: opticron
Patches:
tonezone_compat.diff uploaded by opticron (license 267)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125894
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Brett Bryant [Fri, 27 Jun 2008 16:28:06 +0000 (16:28 +0000)]
Change the way that the transport option works for sip users. transport will now take multiple arguments, the first one listed will be the one used
for new dialogs, and the rest listed will be acceptable ways for that peer to contact us. This fixes a minor bug where, because SIP TCP/UDP run on
the same port, could cause a TCP peer to be saved in the ast_db. There will also be warnings when a transport is changed for an unexpected reason.
(issue #12799)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125891
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Fri, 27 Jun 2008 16:23:32 +0000 (16:23 +0000)]
Optimization suggested by Russell to cache the value of pthread_self() so
that it isn't evaluated every time through the loop.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125880
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Fri, 27 Jun 2008 16:18:07 +0000 (16:18 +0000)]
Remove debug message
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125856
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Fri, 27 Jun 2008 16:16:13 +0000 (16:16 +0000)]
Ensure the thread-safety of the monexec variable in app_queue.
Thanks to Russell for pointing out the problem
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125855
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Fri, 27 Jun 2008 16:00:05 +0000 (16:00 +0000)]
Revert half of the fix, as this part may have been unnecessary (related to issue #12914)
Requested here: http://lists.digium.com/pipermail/asterisk-dev/2008-June/033658.html
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125853
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Fri, 27 Jun 2008 14:14:09 +0000 (14:14 +0000)]
Remove an unneeded target from the Makefile
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125799
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Fri, 27 Jun 2008 14:08:38 +0000 (14:08 +0000)]
Push relatively unused compiler options down the list, keeping the popular options at the top.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125796
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Fri, 27 Jun 2008 13:54:13 +0000 (13:54 +0000)]
Merged revisions 125793 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r125793 | tilghman | 2008-06-27 08:45:03 -0500 (Fri, 27 Jun 2008) | 2 lines
In this debugging function, copy to a buffer instead of using potentially unsafe pointers.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125794
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Fri, 27 Jun 2008 12:28:38 +0000 (12:28 +0000)]
Merged revisions 125740 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r125740 | tilghman | 2008-06-27 07:19:39 -0500 (Fri, 27 Jun 2008) | 7 lines
Add proper deadlock avoidance.
(closes issue #12914)
Reported by: ozan
Patches:
20080625__bug12914.diff.txt uploaded by Corydon76 (license 14)
Tested by: ozan
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125741
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Philippe Sultan [Fri, 27 Jun 2008 07:28:17 +0000 (07:28 +0000)]
Fix a compile time error that occurs if OpenSSL is not installed. Reported by Noel Morais on the users mailing list
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125703
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Fri, 27 Jun 2008 00:22:03 +0000 (00:22 +0000)]
Make this compile with dev-mode on
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125666
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Fri, 27 Jun 2008 00:15:54 +0000 (00:15 +0000)]
The monitor-join option for queues was deprecated in favor of using
MixMonitor to mix audio. However, it was pointed out to me that because
of this, the command set for the MONITOR_EXEC variable is ignored as well.
This means that people can't do their own custom mixing commands at the end
of recordings in order to make, for instance, stereo recordings of calls.
With this patch, app_queue will set the "joinfiles" variable for the channel's
monitor if MONITOR_EXEC is not zero-length. This means that for normal audio
mixing, MixMonitor is still the preferred choice, but we allow custom
mixing to be done with the two Monitor streams if desired.
(closes issue #12923)
Reported by: snyfer
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125649
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Thu, 26 Jun 2008 23:35:29 +0000 (23:35 +0000)]
Improve consistency between app_dial and app_queue with regards
to how language is handled between two channels whose native
language is different. Prior to this patch, app_dial would have
the callee inherit the caller's language, and app_queue would not.
After this patch, app_dial no longer has the language inheritance
capability. This seems to make the most sense since it seems more
natural for a person to hear files played back in his/her native
language instead of the language of the person on the far end of
the call. See the CHANGES file for hints on how to keep the
previous behavior of app_dial if desired.
(closes issue #12489)
Reported by: bcnit
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125647
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Michiel van Baak [Thu, 26 Jun 2008 23:18:46 +0000 (23:18 +0000)]
remove block of commented code to set __ourip
This is now handled in skinny_register and load_config.
part two of chan_skinny cleanup
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125596
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Michiel van Baak [Thu, 26 Jun 2008 23:14:08 +0000 (23:14 +0000)]
remove paging device from chan_skinny.
This has never been used, and noone could give us info about what
it is used for.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125593
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Thu, 26 Jun 2008 23:06:18 +0000 (23:06 +0000)]
Fix a really stupid mistake
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125591
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jason Parker [Thu, 26 Jun 2008 23:04:18 +0000 (23:04 +0000)]
Merged revisions 125587 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r125587 | qwell | 2008-06-26 18:03:15 -0500 (Thu, 26 Jun 2008) | 1 line
Make sure to unlock the lock_info lock (huh?). Possible deadlock?
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125589
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Thu, 26 Jun 2008 23:01:02 +0000 (23:01 +0000)]
Merged revisions 125585 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r125585 | mmichelson | 2008-06-26 17:52:39 -0500 (Thu, 26 Jun 2008) | 11 lines
Add the interface of a queue member to the output of the "queue show" command
so that it can easily be associated with a queue member's name. This helps
so that the appropriate queue member can be removed or paused since the
interface is required, not the member's name.
(closes issue #12783)
Reported by: davevg
Patches:
app_queue.diff uploaded by davevg (license 209) with small mod from me
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125586
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Thu, 26 Jun 2008 22:49:16 +0000 (22:49 +0000)]
Don't hang if the command is blank
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125583
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Thu, 26 Jun 2008 22:03:54 +0000 (22:03 +0000)]
Blocked revisions 125530 via svnmerge
........
r125530 | mmichelson | 2008-06-26 17:02:55 -0500 (Thu, 26 Jun 2008) | 10 lines
Backport of attended transfer queue_log patch from trunk.
This patch allows for attended transfers to be logged in the
queue_log the same way that blind transfers have always been.
It was decided by popular opinion on the asterisk-dev mailing
list that this should be backported to 1.4. Thanks to everyone
who gave an opinion.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125531
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Thu, 26 Jun 2008 20:57:41 +0000 (20:57 +0000)]
Merged revisions 125476 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r125476 | mmichelson | 2008-06-26 15:56:01 -0500 (Thu, 26 Jun 2008) | 11 lines
Prior to this patch, the "queue show" command used cached
information for realtime queues instead of giving up-to-date
info. Now realtime is queried for the latest and greatest in
queue info.
(closes issue #12858)
Reported by: bcnit
Patches:
queue_show.patch uploaded by putnopvut (license 60)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125477
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Thu, 26 Jun 2008 17:40:25 +0000 (17:40 +0000)]
Don't play "your message has been saved" twice.
(closes issue #12893)
Reported by: jaroth
Patches:
duplicate_saved.patch uploaded by jaroth (license 50)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125438
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Thu, 26 Jun 2008 17:06:17 +0000 (17:06 +0000)]
Convert casts to unions, to fix alignment issues on Solaris
(closes issue #12932)
Reported by: snuffy
Patches:
bug_12932_20080627.diff uploaded by snuffy (license 35)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125386
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Olle Johansson [Thu, 26 Jun 2008 16:54:22 +0000 (16:54 +0000)]
Merged revisions 125384 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r125384 | oej | 2008-06-26 18:32:08 +0200 (Tor, 26 Jun 2008) | 3 lines
Add support for peer realm based auth (a few missing lines, the rest is well documented but never worked)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125385
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Kevin P. Fleming [Thu, 26 Jun 2008 15:50:07 +0000 (15:50 +0000)]
Merged revisions 125327 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r125327 | kpfleming | 2008-06-26 10:30:33 -0500 (Thu, 26 Jun 2008) | 5 lines
ensure that (whenever possible) if we generate a log message because an ioctl() call to DAHDI/Zaptel failed, that we include the reason it failed by including the stringified error number
(issue AST-80)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125333
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Thu, 26 Jun 2008 15:37:01 +0000 (15:37 +0000)]
- add get_max_rate timing API call
- change ast_settimeout() to honor max rate in edge cases of file playback
(this will make some warning messages go away at the end of playing back
a file)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125332
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Kevin P. Fleming [Thu, 26 Jun 2008 12:09:24 +0000 (12:09 +0000)]
fix compile failure found by buildbot (go, buildbot!)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125279
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Thu, 26 Jun 2008 11:02:11 +0000 (11:02 +0000)]
Merged revisions 125276 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r125276 | tilghman | 2008-06-26 06:01:21 -0500 (Thu, 26 Jun 2008) | 7 lines
Check for rtcp structure before trying to delete schedule.
(closes issue #12872)
Reported by: destiny6628
Patches:
20080621__bug12872.diff.txt uploaded by Corydon76 (license 14)
Tested by: destiny6628
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125277
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Thu, 26 Jun 2008 01:25:16 +0000 (01:25 +0000)]
Merged revisions 125218 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r125218 | tilghman | 2008-06-25 20:24:26 -0500 (Wed, 25 Jun 2008) | 4 lines
Document ackcall=always.
(closes issue #12852)
Reported by: davidw
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125223
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Thu, 26 Jun 2008 01:11:43 +0000 (01:11 +0000)]
Update sample configuration to match what are now the defaults for the prefix.
(closes issue #12838, related to issue #12198)
Reported by: pabelanger
Patches:
http.conf.diff2 uploaded by pabelanger (license 224)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125191
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Kevin P. Fleming [Wed, 25 Jun 2008 23:05:28 +0000 (23:05 +0000)]
Merged revisions 125132 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r125132 | kpfleming | 2008-06-25 17:21:30 -0500 (Wed, 25 Jun 2008) | 10 lines
allow tonezone to live in a different place than DAHDI/Zaptel, since dahdi-tools and dahdi-linux are now separate packages and can be installed in different places
don't include tonezone.h in dahdi_compat.h, because only a couple of modules need it
get app_rpt building again after the DAHDI changes
(closes issue #12911)
Reported by: tzafrir
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125138
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Wed, 25 Jun 2008 22:40:41 +0000 (22:40 +0000)]
Fix indentation
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125135
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Wed, 25 Jun 2008 22:25:20 +0000 (22:25 +0000)]
Fix a bug in the rwlock tracking. ast_rwlock_unlock did not take into
account that multiple threads could hold the same rdlock at the same time.
As such, it expected that when a thread released a lock that it must have
been the last to acquire the lock as well. Erroneous error messages would
be sent to the console stating that a thread was attempting to unlock a lock
it did not own.
Now all threads are examined to be sure that the message is only printed
when it is supposed to be printed.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125133
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Michiel van Baak [Wed, 25 Jun 2008 19:37:40 +0000 (19:37 +0000)]
implement transfer functionality in chan_skinny
(closes issue #9939)
Reported by: wedhorn
Patches:
transfer_v6.diff uploaded by wedhorn (license 30)
chan_skinny-transfer-trunk-v10.txt uploaded by DEA (license 3)
chan_skinny-transfer-trunk-v12.txt uploaded by mvanbaak (license 7)
Tested by: DEA, wedhorn, mvanbaak
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125096
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Wed, 25 Jun 2008 16:00:54 +0000 (16:00 +0000)]
Separate the global initialization routines for cURL into its own separate
module.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125055
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Wed, 25 Jun 2008 02:34:11 +0000 (02:34 +0000)]
More expansion of the deadlock avoidance macro, including a macro to do locking
of the channel lock
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125020
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Wed, 25 Jun 2008 01:08:37 +0000 (01:08 +0000)]
Merged revisions 124965 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r124965 | tilghman | 2008-06-24 19:46:24 -0500 (Tue, 24 Jun 2008) | 7 lines
Pvt deadlock causes some channels to get stuck in Reserved status.
(closes issue #12621)
Reported by: fabianoheringer
Patches:
20080612__bug12621.diff.txt uploaded by Corydon76 (license 14)
Tested by: fabianoheringer
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124966
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Tue, 24 Jun 2008 21:18:52 +0000 (21:18 +0000)]
Merged revisions 124910 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r124910 | tilghman | 2008-06-24 16:08:52 -0500 (Tue, 24 Jun 2008) | 8 lines
Occasionally control characters find their way into CallerID. These need to
be stripped prior to placing CallerID in the headers of an email.
(closes issue #12759)
Reported by: RobH
Patches:
20080602__bug12759__2.diff.txt uploaded by Corydon76 (license 14)
Tested by: RobH
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124912
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Tue, 24 Jun 2008 20:55:06 +0000 (20:55 +0000)]
Blocked revisions 124908 via svnmerge
........
r124908 | tilghman | 2008-06-24 15:52:43 -0500 (Tue, 24 Jun 2008) | 6 lines
Don't access the pvt structure if unable to acquire the lock.
(closes issue #12162)
Reported by: norman
Patches:
12162-lockfail.diff uploaded by qwell (license 4)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124909
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Philippe Sultan [Tue, 24 Jun 2008 17:50:22 +0000 (17:50 +0000)]
Subscribe to buddy's presence only if we really need to. That is, if
the corresponding roster item has a subscription value set to "none"
or "from".
Make the code more readable.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124872
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Philippe Sultan [Tue, 24 Jun 2008 17:28:39 +0000 (17:28 +0000)]
Code simplification
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124870
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Tue, 24 Jun 2008 11:02:02 +0000 (11:02 +0000)]
Update CHANGES and UPGRADE.txt per kpfleming's mail to #asterisk-dev.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124835
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Tue, 24 Jun 2008 02:16:59 +0000 (02:16 +0000)]
fix a memory leak.
(inspired by, and potentially fixes issue #12917)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124798
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Kevin P. Fleming [Mon, 23 Jun 2008 21:24:34 +0000 (21:24 +0000)]
Blocked revisions 124743 via svnmerge
........
r124743 | kpfleming | 2008-06-23 16:22:08 -0500 (Mon, 23 Jun 2008) | 3 lines
emit a warning if the old IAX2 call searching code finds a call when the new code did not... so that we can get rid of the old code in 2-3 months
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124744
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Dwayne M. Hubbard [Mon, 23 Jun 2008 15:24:05 +0000 (15:24 +0000)]
make solaris happy...pointed out by snuff-home on IRC
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124707
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Sun, 22 Jun 2008 17:36:20 +0000 (17:36 +0000)]
Revert my change to the sample meetme conf file as it was incorrect.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124669
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Sun, 22 Jun 2008 16:34:31 +0000 (16:34 +0000)]
Fix a comment in meetme.conf.sample per jmls via #asterisk-dev
(And this time, do it in the correct repository :-))
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124635
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Sun, 22 Jun 2008 14:12:49 +0000 (14:12 +0000)]
Let app_rpt compile.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124596
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Steve Murphy [Sun, 22 Jun 2008 02:58:06 +0000 (02:58 +0000)]
Merged revisions 124540 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r124540 | murf | 2008-06-21 20:54:52 -0600 (Sat, 21 Jun 2008) | 9 lines
(closes issue #12910)
Reported by: chris-mac
Sorry, my testing did not contain the simple case of forkCDR(v),
I am much embarrassed to admit. If I had, I would have
more solidly initialized the opts element for varset.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124541
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Sat, 21 Jun 2008 12:53:48 +0000 (12:53 +0000)]
Reduce warning to debug, otherwise we flood the log when we (legitimately)
can't find a record.
(Closes issue #12908)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124505
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Fri, 20 Jun 2008 23:13:21 +0000 (23:13 +0000)]
Merged revisions 124450 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r124450 | tilghman | 2008-06-20 18:12:33 -0500 (Fri, 20 Jun 2008) | 6 lines
usleep with a value over 1,000,000 is nonportable. Changing to use sleep()
instead. (closes issue #12814)
Reported by: pputman
Patches:
app_rtp_sleep.patch uploaded by pputman (license 81)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124451
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Fri, 20 Jun 2008 22:04:37 +0000 (22:04 +0000)]
Merged revisions 124395 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r124395 | tilghman | 2008-06-20 17:02:55 -0500 (Fri, 20 Jun 2008) | 3 lines
If the last character in a string to be parsed is the delimiter, then we should
count that final empty string as an additional argument.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124396
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jeff Gehlbach [Fri, 20 Jun 2008 21:43:18 +0000 (21:43 +0000)]
(Missed committing . on previous commit.....)
Merged revisions 124372 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r124372 | jeffg | 2008-06-20 17:14:40 -0400 (Fri, 20 Jun 2008) | 1 line
Fix issues in digium-mib.txt and asterisk-mib.txt to placate smilint - bug 12905
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124393
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jeff Gehlbach [Fri, 20 Jun 2008 21:36:01 +0000 (21:36 +0000)]
Merged revisions 124372 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r124372 | jeffg | 2008-06-20 17:14:40 -0400 (Fri, 20 Jun 2008) | 1 line
Fix issues in digium-mib.txt and asterisk-mib.txt to placate smilint - bug 12905
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124392
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Fri, 20 Jun 2008 20:17:04 +0000 (20:17 +0000)]
Merged revisions 124315 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r124315 | tilghman | 2008-06-20 15:16:02 -0500 (Fri, 20 Jun 2008) | 8 lines
When using a Local channel, started by a call file, with a destination of an
AGI script, the AGI script does not always get notified of a hangup if the
underlying channel hangs up early.
(closes issue #11833)
Reported by: IgorG
Patches:
local_hangup-v1.diff uploaded by IgorG (license 20)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124316
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Fri, 20 Jun 2008 16:30:18 +0000 (16:30 +0000)]
Change references to doc/channelvariables.txt to
doc/tex/channelvariables.tex.
This issue came up on the asterisk-dev mailing list.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124278
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Fri, 20 Jun 2008 15:20:11 +0000 (15:20 +0000)]
Add a missing "ChannelType" header to one of the "PeerStatus" manager
events in chan_sip
(closes issue #12904)
Reported by: eliel
Patches:
chan_sip.c.patch uploaded by eliel (license 64)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124243
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Thu, 19 Jun 2008 22:59:41 +0000 (22:59 +0000)]
Merged revisions 124182 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r124182 | tilghman | 2008-06-19 17:53:22 -0500 (Thu, 19 Jun 2008) | 7 lines
It's possible for a hangup to be received, even just after the initial cid
spill.
(closes issue #12453)
Reported by: Alex728
Patches:
20080604__bug12453.diff.txt uploaded by Corydon76 (license 14)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124183
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Thu, 19 Jun 2008 22:34:03 +0000 (22:34 +0000)]
Fix attachment behavior when using IMAP storage for voicemails
1. Filenames had an extra "msg" in the attachment name
2. The attachment was being saved twice
(closes issue #12894)
Reported by: jaroth
Patches:
imap_attach.patch uploaded by jaroth (license 50)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124180
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Michiel van Baak [Thu, 19 Jun 2008 20:48:33 +0000 (20:48 +0000)]
Older versions of GNU gcc do not allow 'NULL' as sentinel.
They want (char *)NULL as sentinel.
An example is OpenBSD (confirmed on 4.3) that ships with gcc 3.3.4
This commit introduces a contstant SENTINEL which is declared as:
#define SENTINEL ((char *)NULL)
All places I could test compile on my openbsd system are converted.
Update CODING-GUIDELINES to tell about this constant.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124127
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Thu, 19 Jun 2008 20:35:56 +0000 (20:35 +0000)]
Oops
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124125
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Thu, 19 Jun 2008 20:30:23 +0000 (20:30 +0000)]
Merged revisions 124112 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r124112 | mmichelson | 2008-06-19 15:28:41 -0500 (Thu, 19 Jun 2008) | 8 lines
Fix IMAP forwarding so that messages are sent to the proper mailbox.
(closes issue #12897)
Reported by: jaroth
Patches:
destination_forward.patch uploaded by jaroth (license 50)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124121
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Thu, 19 Jun 2008 20:25:37 +0000 (20:25 +0000)]
Make OpenBSD compile again
(reported by mvanbaak via IRC -dev)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124102
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Brett Bryant [Thu, 19 Jun 2008 19:48:26 +0000 (19:48 +0000)]
Add errors that report any locks held by threads when they are being closed.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124064
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Thu, 19 Jun 2008 19:22:59 +0000 (19:22 +0000)]
Allow alternative extensions to be specified for a user.
(closes issue #12830)
Reported by: jcollie
Patches:
astertisk-trunk-121496-alternate-extensions.patch uploaded by jcollie (license 412)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124049
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Brett Bryant [Thu, 19 Jun 2008 18:57:04 +0000 (18:57 +0000)]
Fix bug in sip registration that sets the default port to 5060 for tls.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124024
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Thu, 19 Jun 2008 18:30:49 +0000 (18:30 +0000)]
- Make res_timing_pthread allow a max rate of 100/sec instead of 50/sec
- change the "timing test" CLI command to let you specify a timing rate to test
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124023
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Thu, 19 Jun 2008 17:55:34 +0000 (17:55 +0000)]
Detect if the installed gcc version supports the warn_unused_result attribute.
Reported by mvanbaak via IRC -dev.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123988
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Thu, 19 Jun 2008 17:22:27 +0000 (17:22 +0000)]
Don't change pointers that need to be later passed back for deallocation.
(closes issue #12572)
Reported by: flyn
Patches:
20080613__bug12572.diff.txt uploaded by Corydon76 (license 14)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123952
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Thu, 19 Jun 2008 17:02:54 +0000 (17:02 +0000)]
Merged revisions 123930 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r123930 | tilghman | 2008-06-19 11:58:19 -0500 (Thu, 19 Jun 2008) | 5 lines
Change informative messages to use the _multiple variant when multiple formats
are possible.
(Closes issue #12848)
Reported by klaus3000
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123931
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Thu, 19 Jun 2008 16:26:50 +0000 (16:26 +0000)]
Merged revisions 123909 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r123909 | tilghman | 2008-06-19 11:26:03 -0500 (Thu, 19 Jun 2008) | 5 lines
Only process 40 arguments (20 files) at once with xargs, because some older
shells may force xargs to separate on an odd boundary.
(Closes issue #12883)
Reported by Nik Soggia
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123913
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Thu, 19 Jun 2008 16:21:32 +0000 (16:21 +0000)]
Merged revisions 123883 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r123883 | tilghman | 2008-06-19 11:20:41 -0500 (Thu, 19 Jun 2008) | 4 lines
Correct description of notifyringing option.
(Closes issue #12890)
Reported by gminet
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123887
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Thu, 19 Jun 2008 16:08:29 +0000 (16:08 +0000)]
Merged revisions 123869 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r123869 | tilghman | 2008-06-19 11:07:23 -0500 (Thu, 19 Jun 2008) | 6 lines
The RDTSC instruction was introduced on the Pentium line of microprocessors,
and is not compatible with certain 586 clones, like Cyrix. Hence, asking for
i386 compatibility was always incorrect. See http://en.wikipedia.org/wiki/RDTSC
(Closes issue #12886)
Reported by tecnoxarxa
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123870
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Thu, 19 Jun 2008 15:55:10 +0000 (15:55 +0000)]
Forwarding non-urgent IMAP messages could inadvertently cause the messages
to be marked urgent. This fixes that issue.
(closes issue #12895)
Reported by: jaroth
Patches:
urgent_forwarding.patch uploaded by jaroth (license 50)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123867
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Thu, 19 Jun 2008 15:52:17 +0000 (15:52 +0000)]
Missing comma
(closes issue #12891)
Reported by: chris-mac
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123865
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Thu, 19 Jun 2008 14:28:56 +0000 (14:28 +0000)]
Update the queuelog.tex documentation as well.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123830
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Thu, 19 Jun 2008 14:24:43 +0000 (14:24 +0000)]
Include original position in TRANSFER entries written to queue_log.
(closes issue #12888)
Reported by: slavon
Patches:
app_queue_transfer_patch_trunk.diff uploaded by slavon (license 288)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123828
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Wed, 18 Jun 2008 22:17:17 +0000 (22:17 +0000)]
Merged revisions 123769 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r123769 | tilghman | 2008-06-18 17:08:30 -0500 (Wed, 18 Jun 2008) | 8 lines
Add support for saying numbers in Hebrew.
(closes issue #11662)
Reported by: greenfieldtech
Patches:
say.c.patch-
12042008 uploaded by greenfieldtech (license 369)
Hebrew-Sounds.ods uploaded by greenfieldtech
(with signficant changes to the spreadsheet by me)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123770
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Wed, 18 Jun 2008 20:23:58 +0000 (20:23 +0000)]
Merged revisions 123710 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r123710 | tilghman | 2008-06-18 15:22:42 -0500 (Wed, 18 Jun 2008) | 7 lines
Set the variables top-down, so that if a script sets a variable more than once,
the last one will take precedence.
(closes issue #12673)
Reported by: phber
Patches:
20080519__bug12673.diff.txt uploaded by Corydon76 (license 14)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123715
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Brett Bryant [Wed, 18 Jun 2008 20:07:56 +0000 (20:07 +0000)]
Fix a crash in tcp and tls connections related to reference counts.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123692
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Wed, 18 Jun 2008 15:08:56 +0000 (15:08 +0000)]
A portion of the code which handled the 'c' queue option had been
removed. No telling when it happened. Anyway, it's back in now
and works properly.
(Based on issue reported on mailing list)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123652
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Wed, 18 Jun 2008 14:54:47 +0000 (14:54 +0000)]
Silly pointers. This fixes a memory corruption I introduced
with the attended transfer logging.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123650
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Wed, 18 Jun 2008 13:09:02 +0000 (13:09 +0000)]
Channel lock janitor -- add locks around retrieval of channel variables
(closes issue #12840)
Reported by: pputman
Patches:
app_dial_threadsafe3.patch uploaded by pputman (license 81)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123648
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Wed, 18 Jun 2008 00:33:31 +0000 (00:33 +0000)]
Whitespace only
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123609
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Brett Bryant [Tue, 17 Jun 2008 22:24:45 +0000 (22:24 +0000)]
Revert a previous regression in astobj2.c from merging a branch.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123575
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Brett Bryant [Tue, 17 Jun 2008 21:46:57 +0000 (21:46 +0000)]
Updates all usages of ast_tcptls_session_instance to be managed by reference counts so that they only get destroyed when all threads are done using
them, and memory does not get free'd causing strange issues with SIP.
This code was originally written by russellb in the team/group/issue_11972/ branch.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123546
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Tue, 17 Jun 2008 21:42:42 +0000 (21:42 +0000)]
Add an option, specifying maximum analysis time for talk detection.
(closes issue #12149)
Reported by: davevg
Patches:
app_talkdetect.c.diff uploaded by davevg (license 209)
(Plus a few additional cleanups by moi)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123544
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Tue, 17 Jun 2008 21:33:40 +0000 (21:33 +0000)]
Put quotes around "test"
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123541
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Tue, 17 Jun 2008 21:26:31 +0000 (21:26 +0000)]
_ys pointed out in #asterisk-bugs that he was experiencing
a memory leak when running the astobj2 test CLI command. After
searching, it appears the leak was in the command handler itself.
Each object was allocated (recount = 1) and then linked into
a container (refounct = 2). Then at the end of the function,
the container was unreffed, causing all the objects to have
their refcount decremented by one, leaving the refcount for
all objects allocated in that function at 1. I've now added
an extra unref to the mix so that the refcount equals zero
when the container is unreffed.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123526
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Tue, 17 Jun 2008 20:28:47 +0000 (20:28 +0000)]
Merged revisions 123485 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r123485 | mmichelson | 2008-06-17 15:26:38 -0500 (Tue, 17 Jun 2008) | 4 lines
Make chan_sip build under dev mode with compilers >= GCC 4.2
Thanks to jpeeler for alerting me of this
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123486
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Tue, 17 Jun 2008 20:19:49 +0000 (20:19 +0000)]
Add the same fix from revision 123271 to container_destruct_debug.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123456
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Steve Murphy [Tue, 17 Jun 2008 20:17:20 +0000 (20:17 +0000)]
Changes to list peers and users in alpha. order, as per a reasonable request in 12494. Due to changes in trunk to use the astobj2 i/f in the sip channel driver, the order of the entries in the config file was lost, thus the output was in a random order, but no longer.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123448
65c4cc65-6c06-0410-ace0-
fbb531ad65f3